Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp

Issue 2894103002: Int and Float properties for Accessibility Object Model phase 1 (Closed)
Patch Set: Update webexposed/ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp b/third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp
index 6182bae019b39658af393b9fce5a7ea862dc21be..3ea26dee4376e242aa1661ef95e1862ff8a073ef 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp
@@ -20,6 +20,7 @@
#include "modules/accessibility/AXProgressIndicator.h"
+#include "core/dom/AccessibleNode.h"
#include "core/html/HTMLProgressElement.h"
#include "core/layout/LayoutProgress.h"
#include "modules/accessibility/AXObjectCacheImpl.h"
@@ -51,8 +52,9 @@ bool AXProgressIndicator::ComputeAccessibilityIsIgnored(
}
float AXProgressIndicator::ValueForRange() const {
- if (HasAttribute(aria_valuenowAttr))
- return GetAttribute(aria_valuenowAttr).ToFloat();
+ float value_now;
+ if (HasAOMPropertyOrARIAAttribute(AOMFloatProperty::kValueNow, value_now))
+ return value_now;
if (GetProgressElement()->position() >= 0)
return clampTo<float>(GetProgressElement()->value());
@@ -61,15 +63,17 @@ float AXProgressIndicator::ValueForRange() const {
}
float AXProgressIndicator::MaxValueForRange() const {
- if (HasAttribute(aria_valuemaxAttr))
- return GetAttribute(aria_valuemaxAttr).ToFloat();
+ float value_max;
+ if (HasAOMPropertyOrARIAAttribute(AOMFloatProperty::kValueMax, value_max))
+ return value_max;
return clampTo<float>(GetProgressElement()->max());
}
float AXProgressIndicator::MinValueForRange() const {
- if (HasAttribute(aria_valueminAttr))
- return GetAttribute(aria_valueminAttr).ToFloat();
+ float value_min;
+ if (HasAOMPropertyOrARIAAttribute(AOMFloatProperty::kValueMin, value_min))
+ return value_min;
return 0.0f;
}

Powered by Google App Engine
This is Rietveld 408576698