Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.h

Issue 2894093002: Don't access DisplayItemClient::VisualRect() for cached display items. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
index 3ebb855ebb936c40f8b7ed5939a5b70037615411..d186158f6d5ee3c551e673d804c71fa66c4618c5 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
@@ -140,11 +140,8 @@ class PLATFORM_EXPORT PaintController {
}
bool IsSkippingCache() const { return skipping_cache_count_; }
- // Must be called when a painting is finished. |offsetFromLayoutObject| is the
- // offset between the space of the GraphicsLayer which owns this
- // PaintController and the coordinate space of the owning LayoutObject.
- void CommitNewDisplayItems(
- const LayoutSize& offset_from_layout_object = LayoutSize());
+ // Must be called when a painting is finished.
+ void CommitNewDisplayItems();
// Returns the approximate memory usage, excluding memory likely to be
// shared with the embedder after copying to WebPaintController.
@@ -185,11 +182,9 @@ class PLATFORM_EXPORT PaintController {
// the last commitNewDisplayItems(). Use with care.
DisplayItemList& NewDisplayItemList() { return new_display_item_list_; }
- void AppendDebugDrawingAfterCommit(
- const DisplayItemClient&,
- sk_sp<PaintRecord>,
- const FloatRect& record_bounds,
- const LayoutSize& offset_from_layout_object);
+ void AppendDebugDrawingAfterCommit(const DisplayItemClient&,
+ sk_sp<PaintRecord>,
+ const FloatRect& record_bounds);
void ShowDebugData() const { ShowDebugDataInternal(false); }
#ifndef NDEBUG

Powered by Google App Engine
This is Rietveld 408576698