third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h - Issue 2894093002: Don't access DisplayItemClient::VisualRect() for cached display items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h

Issue 2894093002: Don't access DisplayItemClient::VisualRect() for cached display items. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp ('K') | « third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItemTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h

diff --git a/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h b/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h

index bc883fab3331cc293645ba0cdf0b115b4e0bb750..ff8494043d393cce6f23092a0e9dc71de9f4f12d 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h

+++ b/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h

@@ -31,7 +31,7 @@ class PLATFORM_EXPORT BeginFilterDisplayItem final

origin_(origin) {}

void Replay(GraphicsContext&) const override;

- void AppendToWebDisplayItemList(const IntRect&,

+ void AppendToWebDisplayItemList(const LayoutSize&,

WebDisplayItemList*) const override;

bool DrawsContent() const override;

@@ -64,7 +64,7 @@ class PLATFORM_EXPORT EndFilterDisplayItem final : public PairedEndDisplayItem {

: PairedEndDisplayItem(client, kEndFilter, sizeof(*this)) {}

void Replay(GraphicsContext&) const override;

- void AppendToWebDisplayItemList(const IntRect&,

+ void AppendToWebDisplayItemList(const LayoutSize&,

WebDisplayItemList*) const override;

private: