Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp

Issue 2894093002: Don't access DisplayItemClient::VisualRect() for cached display items. (Closed)
Patch Set: - Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/graphics/paint/PaintChunker.h" 5 #include "platform/graphics/paint/PaintChunker.h"
6 6
7 #include "platform/testing/PaintPropertyTestHelpers.h" 7 #include "platform/testing/PaintPropertyTestHelpers.h"
8 #include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h" 8 #include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h"
9 #include "testing/gmock/include/gmock/gmock.h" 9 #include "testing/gmock/include/gmock/gmock.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 17 matching lines...) Expand all
28 }; 28 };
29 TestDisplayItemClient client_; 29 TestDisplayItemClient client_;
30 }; 30 };
31 31
32 class TestDisplayItem : public DisplayItem { 32 class TestDisplayItem : public DisplayItem {
33 public: 33 public:
34 TestDisplayItem(const DisplayItemClient& client, DisplayItem::Type type) 34 TestDisplayItem(const DisplayItemClient& client, DisplayItem::Type type)
35 : DisplayItem(client, type, sizeof(*this)) {} 35 : DisplayItem(client, type, sizeof(*this)) {}
36 36
37 void Replay(GraphicsContext&) const final { NOTREACHED(); } 37 void Replay(GraphicsContext&) const final { NOTREACHED(); }
38 void AppendToWebDisplayItemList(const IntRect&, 38 void AppendToWebDisplayItemList(const LayoutSize&,
39 WebDisplayItemList*) const final { 39 WebDisplayItemList*) const final {
40 NOTREACHED(); 40 NOTREACHED();
41 } 41 }
42 }; 42 };
43 43
44 class NormalTestDisplayItem : public TestDisplayItem { 44 class NormalTestDisplayItem : public TestDisplayItem {
45 public: 45 public:
46 NormalTestDisplayItem(const DisplayItemClient& client) 46 NormalTestDisplayItem(const DisplayItemClient& client)
47 : TestDisplayItem(client, DisplayItem::kDrawingFirst) {} 47 : TestDisplayItem(client, DisplayItem::kDrawingFirst) {}
48 }; 48 };
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 chunks, 379 chunks,
380 ElementsAre(PaintChunk(0, 2, nullptr, DefaultPaintChunkProperties()), 380 ElementsAre(PaintChunk(0, 2, nullptr, DefaultPaintChunkProperties()),
381 PaintChunk(2, 4, nullptr, simple_transform), 381 PaintChunk(2, 4, nullptr, simple_transform),
382 PaintChunk(4, 5, nullptr, simple_transform), 382 PaintChunk(4, 5, nullptr, simple_transform),
383 PaintChunk(5, 6, nullptr, simple_transform), 383 PaintChunk(5, 6, nullptr, simple_transform),
384 PaintChunk(6, 7, nullptr, DefaultPaintChunkProperties()))); 384 PaintChunk(6, 7, nullptr, DefaultPaintChunkProperties())));
385 } 385 }
386 386
387 } // namespace 387 } // namespace
388 } // namespace blink 388 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698