Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp

Issue 2894093002: Don't access DisplayItemClient::VisualRect() for cached display items. (Closed)
Patch Set: - Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/graphics/paint/DisplayItem.h" 5 #include "platform/graphics/paint/DisplayItem.h"
6 6
7 namespace blink { 7 namespace blink {
8 8
9 struct SameSizeAsDisplayItem { 9 struct SameSizeAsDisplayItem {
10 virtual ~SameSizeAsDisplayItem() {} // Allocate vtable pointer. 10 virtual ~SameSizeAsDisplayItem() {} // Allocate vtable pointer.
11 void* pointer; 11 void* pointer;
12 LayoutRect rect;
12 int i; 13 int i;
13 #ifndef NDEBUG 14 #ifndef NDEBUG
14 WTF::String debug_string_; 15 WTF::String debug_string_;
15 #endif 16 #endif
16 }; 17 };
17 static_assert(sizeof(DisplayItem) == sizeof(SameSizeAsDisplayItem), 18 static_assert(sizeof(DisplayItem) == sizeof(SameSizeAsDisplayItem),
18 "DisplayItem should stay small"); 19 "DisplayItem should stay small");
19 20
20 #ifndef NDEBUG 21 #ifndef NDEBUG
21 22
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 // This is the original debug string which is in json format. 238 // This is the original debug string which is in json format.
238 string_builder.Append(ClientDebugString()); 239 string_builder.Append(ClientDebugString());
239 return; 240 return;
240 } 241 }
241 242
242 string_builder.Append(String::Format("client: \"%p", &Client())); 243 string_builder.Append(String::Format("client: \"%p", &Client()));
243 if (!ClientDebugString().IsEmpty()) { 244 if (!ClientDebugString().IsEmpty()) {
244 string_builder.Append(' '); 245 string_builder.Append(' ');
245 string_builder.Append(ClientDebugString()); 246 string_builder.Append(ClientDebugString());
246 } 247 }
248 string_builder.Append("\", visualRect: \"");
249 string_builder.Append(VisualRect().ToString());
247 string_builder.Append("\", type: \""); 250 string_builder.Append("\", type: \"");
248 string_builder.Append(TypeAsDebugString(GetType())); 251 string_builder.Append(TypeAsDebugString(GetType()));
249 string_builder.Append('"'); 252 string_builder.Append('"');
250 if (skipped_cache_) 253 if (skipped_cache_)
251 string_builder.Append(", skippedCache: true"); 254 string_builder.Append(", skippedCache: true");
252 } 255 }
253 256
254 #endif 257 #endif
255 258
256 } // namespace blink 259 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698