Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2894093002: Don't access DisplayItemClient::VisualRect() for cached display items. (Closed)
Patch Set: - Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 3265 matching lines...) Expand 10 before | Expand all | Expand 10 after
3276 ForAllNonThrottledFrameViews([](FrameView& frame_view) { 3276 ForAllNonThrottledFrameViews([](FrameView& frame_view) {
3277 frame_view.Lifecycle().AdvanceTo(DocumentLifecycle::kInPaint); 3277 frame_view.Lifecycle().AdvanceTo(DocumentLifecycle::kInPaint);
3278 }); 3278 });
3279 3279
3280 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { 3280 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
3281 if (GetLayoutView()->Layer()->NeedsRepaint()) { 3281 if (GetLayoutView()->Layer()->NeedsRepaint()) {
3282 GraphicsContext graphics_context(*paint_controller_); 3282 GraphicsContext graphics_context(*paint_controller_);
3283 if (RuntimeEnabledFeatures::printBrowserEnabled()) 3283 if (RuntimeEnabledFeatures::printBrowserEnabled())
3284 graphics_context.SetPrinting(true); 3284 graphics_context.SetPrinting(true);
3285 Paint(graphics_context, CullRect(LayoutRect::InfiniteIntRect())); 3285 Paint(graphics_context, CullRect(LayoutRect::InfiniteIntRect()));
3286 paint_controller_->CommitNewDisplayItems(LayoutSize()); 3286 paint_controller_->CommitNewDisplayItems();
3287 } 3287 }
3288 } else { 3288 } else {
3289 // A null graphics layer can occur for painting of SVG images that are not 3289 // A null graphics layer can occur for painting of SVG images that are not
3290 // parented into the main frame tree, or when the FrameView is the main 3290 // parented into the main frame tree, or when the FrameView is the main
3291 // frame view of a page overlay. The page overlay is in the layer tree of 3291 // frame view of a page overlay. The page overlay is in the layer tree of
3292 // the host page and will be painted during painting of the host page. 3292 // the host page and will be painted during painting of the host page.
3293 if (GraphicsLayer* root_graphics_layer = 3293 if (GraphicsLayer* root_graphics_layer =
3294 view.Compositor()->RootGraphicsLayer()) { 3294 view.Compositor()->RootGraphicsLayer()) {
3295 PaintGraphicsLayerRecursively(root_graphics_layer); 3295 PaintGraphicsLayerRecursively(root_graphics_layer);
3296 } 3296 }
(...skipping 2124 matching lines...) Expand 10 before | Expand all | Expand 10 after
5421 void FrameView::SetAnimationHost( 5421 void FrameView::SetAnimationHost(
5422 std::unique_ptr<CompositorAnimationHost> host) { 5422 std::unique_ptr<CompositorAnimationHost> host) {
5423 animation_host_ = std::move(host); 5423 animation_host_ = std::move(host);
5424 } 5424 }
5425 5425
5426 LayoutUnit FrameView::CaretWidth() const { 5426 LayoutUnit FrameView::CaretWidth() const {
5427 return LayoutUnit(GetChromeClient()->WindowToViewportScalar(1)); 5427 return LayoutUnit(GetChromeClient()->WindowToViewportScalar(1));
5428 } 5428 }
5429 5429
5430 } // namespace blink 5430 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698