Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js

Issue 2894083002: [DevTools] Set row background instead of the table (Closed)
Patch Set: Fixed a comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 // Common.UIString("(%s) Created: %s Updated: %s", this._size, this._creatio nTime, this._updateTime); 178 // Common.UIString("(%s) Created: %s Updated: %s", this._size, this._creatio nTime, this._updateTime);
179 } 179 }
180 180
181 _createDataGrid() { 181 _createDataGrid() {
182 var columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([ 182 var columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
183 {id: 'resource', title: Common.UIString('Resource'), sort: DataGrid.DataGr id.Order.Ascending, sortable: true}, 183 {id: 'resource', title: Common.UIString('Resource'), sort: DataGrid.DataGr id.Order.Ascending, sortable: true},
184 {id: 'type', title: Common.UIString('Type'), sortable: true}, 184 {id: 'type', title: Common.UIString('Type'), sortable: true},
185 {id: 'size', title: Common.UIString('Size'), align: DataGrid.DataGrid.Alig n.Right, sortable: true} 185 {id: 'size', title: Common.UIString('Size'), align: DataGrid.DataGrid.Alig n.Right, sortable: true}
186 ]); 186 ]);
187 this._dataGrid = new DataGrid.DataGrid(columns); 187 this._dataGrid = new DataGrid.DataGrid(columns);
188 this._dataGrid.setStriped(true);
188 this._dataGrid.asWidget().show(this.element); 189 this._dataGrid.asWidget().show(this.element);
189 this._dataGrid.addEventListener(DataGrid.DataGrid.Events.SortingChanged, thi s._populateDataGrid, this); 190 this._dataGrid.addEventListener(DataGrid.DataGrid.Events.SortingChanged, thi s._populateDataGrid, this);
190 } 191 }
191 192
192 _populateDataGrid() { 193 _populateDataGrid() {
193 var selectedResource = this._dataGrid.selectedNode ? this._dataGrid.selected Node.resource : null; 194 var selectedResource = this._dataGrid.selectedNode ? this._dataGrid.selected Node.resource : null;
194 var sortDirection = this._dataGrid.isSortOrderAscending() ? 1 : -1; 195 var sortDirection = this._dataGrid.isSortOrderAscending() ? 1 : -1;
195 196
196 function numberCompare(field, resource1, resource2) { 197 function numberCompare(field, resource1, resource2) {
197 return sortDirection * (resource1[field] - resource2[field]); 198 return sortDirection * (resource1[field] - resource2[field]);
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 // FIXME: Delete Button semantics are not yet defined. (Delete a single, or all?) 250 // FIXME: Delete Button semantics are not yet defined. (Delete a single, or all?)
250 this._deleteCallback(this._dataGrid.selectedNode); 251 this._deleteCallback(this._dataGrid.selectedNode);
251 } 252 }
252 253
253 _deleteCallback(node) { 254 _deleteCallback(node) {
254 // FIXME: Should we delete a single (selected) resource or all resources? 255 // FIXME: Should we delete a single (selected) resource or all resources?
255 // Protocol.inspectorBackend.deleteCachedResource(...) 256 // Protocol.inspectorBackend.deleteCachedResource(...)
256 // this._update(); 257 // this._update();
257 } 258 }
258 }; 259 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698