third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp - Issue 2894063002: Expose UseCounter::Feature enum out of blink as WebFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

Issue 2894063002: Expose UseCounter::Feature enum out of blink as WebFeature (Closed)

Patch Set: Rebase update Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

index 44597084a7e5e64d89b610428a911f11040186c1..941fa00a9212dbddfa1d654fc66bc8c16fb4c394 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

@@ -26,6 +26,7 @@

#include "platform/bindings/V8PrivateProperty.h"

#include "platform/wtf/GetPtr.h"

#include "platform/wtf/RefPtr.h"

+#include "public/platform/WebFeature.h"

namespace blink {

@@ -397,7 +398,7 @@ void V8TestInterfaceConstructorConstructor::NamedConstructorAttributeGetter(

}

void V8TestInterfaceConstructor::constructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {

- UseCounter::Count(CurrentExecutionContext(info.GetIsolate()), UseCounter::kTestFeature);

+ UseCounter::Count(CurrentExecutionContext(info.GetIsolate()), WebFeature::kTestFeature);

if (!info.IsConstructCall()) {

V8ThrowException::ThrowTypeError(info.GetIsolate(), ExceptionMessages::ConstructorNotCallableAsFunction("TestInterfaceConstructor"));

return;