third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl - Issue 2894063002: Expose UseCounter::Feature enum out of blink as WebFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl

Issue 2894063002: Expose UseCounter::Feature enum out of blink as WebFeature (Closed)

Patch Set: Initial check in Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl

index 197a07527f4577b66be5623565f20512514c9337..6af4d066feb6571e373b83cf49e850bb4305d0ed 100644

--- a/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl

@@ -632,7 +632,7 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info) {

{% if constructors or has_custom_constructor or has_event_constructor or has_html_constructor %}

void {{v8_class}}::constructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {

{% if measure_as %}

- UseCounter::Count(CurrentExecutionContext(info.GetIsolate()), UseCounter::k{{measure_as('Constructor')}});

+ UseCounter::Count(CurrentExecutionContext(info.GetIsolate()), WebFeature::k{{measure_as('Constructor')}});

{% endif %}

if (!info.IsConstructCall()) {

V8ThrowException::ThrowTypeError(info.GetIsolate(), ExceptionMessages::ConstructorNotCallableAsFunction("{{interface_name}}"));