content/browser/renderer_host/input/touch_selection_controller_client_child_frame.cc - Issue 2894043002: Add machinery to show touch editing context menus in OOPIFs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/touch_selection_controller_client_child_frame.cc

Issue 2894043002: Add machinery to show touch editing context menus in OOPIFs. (Closed)

Patch Set: Remove WVI call to WFWI. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/touch_selection_controller_client_aura.cc ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/touch_selection_controller_client_child_frame.cc

diff --git a/content/browser/renderer_host/input/touch_selection_controller_client_child_frame.cc b/content/browser/renderer_host/input/touch_selection_controller_client_child_frame.cc

index b1d7c2bb94f7ba1fffdb02414bb6db15d092578c..22aa5138536966469c62c750c1acde641243abd2 100644

--- a/content/browser/renderer_host/input/touch_selection_controller_client_child_frame.cc

+++ b/content/browser/renderer_host/input/touch_selection_controller_client_child_frame.cc

@@ -9,7 +9,7 @@

#include "content/browser/renderer_host/render_widget_host_delegate.h"

#include "content/browser/renderer_host/render_widget_host_impl.h"

#include "content/common/content_switches_internal.h"

-#include "content/common/view_messages.h"

+#include "content/common/frame_messages.h"

#include "ui/base/clipboard/clipboard.h"

#include "ui/gfx/geometry/point_conversions.h"

#include "ui/strings/grit/ui_strings.h"

@@ -184,12 +184,9 @@ void TouchSelectionControllerClientChildFrame::RunContextMenu() {

anchor_point.Offset(-origin.x(), -origin.y());

RenderWidgetHostImpl* host =

RenderWidgetHostImpl::From(rwhv_->GetRenderWidgetHost());

- // TODO(wjmaclean): Probably this ViewMsg should be converted to a FrameMsg

- // since it will need to go to a RenderFrame once the Blink-side plumbing for

- // this is hooked up.

- host->Send(new ViewMsg_ShowContextMenu(host->GetRoutingID(),

- ui::MENU_SOURCE_TOUCH_EDIT_MENU,

- gfx::ToRoundedPoint(anchor_point)));

+ host->Send(new FrameMsg_ShowContextMenu(host->GetRoutingID(),

EhsanK 2017/05/23 22:31:23 Just curious if host->ShowContextMenuAtPoint() wou

wjmaclean 2017/05/24 13:05:52 It might ... in preparing this CL I followed the e

+ ui::MENU_SOURCE_TOUCH_EDIT_MENU,

+ gfx::ToRoundedPoint(anchor_point)));

// Hide selection handles after getting rect-between-bounds from touch

// selection controller; otherwise, rect would be empty and the above