Add machinery to show touch editing context menus in OOPIFs.

third_party/WebKit/Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 35 matching lines @@
 #include "core/editing/InputMethodController.h"
 #include "core/editing/iterators/TextIterator.h"
 #include "core/editing/serializers/HTMLInterchange.h"
 #include "core/editing/serializers/Serialization.h"
 #include "core/events/KeyboardEvent.h"
 #include "core/events/UIEventWithKeyState.h"
 #include "core/events/WebInputEventConversion.h"
 #include "core/events/WheelEvent.h"
 #include "core/exported/WebPluginContainerBase.h"
 #include "core/frame/BrowserControls.h"
+#include "core/frame/ContextMenuAllowedScope.h"
 #include "core/frame/EventHandlerRegistry.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/LocalFrameClient.h"
 #include "core/frame/PageScaleConstraintsSet.h"
 #include "core/frame/RemoteFrame.h"
 #include "core/frame/ResizeViewportAnchor.h"
 #include "core/frame/RotationViewportAnchor.h"
 #include "core/frame/Settings.h"
 #include "core/frame/UseCounter.h"
@@ skipping 88 matching lines @@
 #include "public/web/WebPlugin.h"
 #include "public/web/WebPluginAction.h"
 #include "public/web/WebRange.h"
 #include "public/web/WebScopedUserGesture.h"
 #include "public/web/WebSelection.h"
 #include "public/web/WebViewClient.h"
 #include "public/web/WebWindowFeatures.h"
 #include "web/AnimationWorkletProxyClientImpl.h"
 #include "web/CompositorMutatorImpl.h"
 #include "web/CompositorWorkerProxyClientImpl.h"
-#include "web/ContextMenuAllowedScope.h"
 #include "web/DedicatedWorkerMessagingProxyProviderImpl.h"
 #include "web/DevToolsEmulator.h"
 #include "web/FullscreenController.h"
 #include "web/LinkHighlightImpl.h"
 #include "web/PageOverlay.h"
 #include "web/PrerendererClientImpl.h"
 #include "web/StorageQuotaClientImpl.h"
 #include "web/WebDevToolsAgentImpl.h"
 #include "web/WebInputMethodControllerImpl.h"
 #include "web/WebLocalFrameImpl.h"
@@ skipping 3325 matching lines @@
   if (!menu)
     return;
   const ContextMenuItem* item = menu->ItemWithAction(
       static_cast<ContextMenuAction>(kContextMenuItemBaseCustomTag + action));
   if (item)
     page_->GetContextMenuController().ContextMenuItemSelected(item);
   page_->GetContextMenuController().ClearContextMenu();
 }
 
 void WebViewImpl::ShowContextMenu() {
-  if (!GetPage())
-    return;
-
-  GetPage()->GetContextMenuController().ClearContextMenu();
-  {
-    ContextMenuAllowedScope scope;
-    if (LocalFrame* focused_frame =
-            ToLocalFrame(GetPage()->GetFocusController().FocusedOrMainFrame()))
-      focused_frame->GetEventHandler().SendContextMenuEventForKey(nullptr);
-  }
+  NOTREACHED();

[EhsanK, 2017/05/23 22:31:23]

To me it looks like this could in fact hit. Here is the scenario I am thinking
of:

1- Browser calls TSCCA::RunContextMenu() and the IPC is sent to the renderer
process.

2- At the same time, renderer navigates to a cross origin site so RenderViewImpl
swaps out.

3- IPC arrives at RenderWidget which no longer has a WebFrameWidget so
GetWebWidget() returns a WebViewImpl.

A though: Is it possible to send the IPC to RenderFrameImpl instead? In
RenderFrameImpl there is a deterministic way of getting the WebFrameWidget.

[wjmaclean, 2017/05/24 13:05:52]

So then, would the previous patchset of this CL, in which
WebViewImpl::ShowContextMenu() then calls the WebFrameWidget implementation, be
better?
That's a possibility if the method from the previous patchset doesn't work.

 }
 
 void WebViewImpl::DidCloseContextMenu() {
   LocalFrame* frame = page_->GetFocusController().FocusedFrame();
   if (frame)
     frame->Selection().SetCaretBlinkingSuspended(false);
 }
 
 void WebViewImpl::HidePopups() {
   CancelPagePopup();
@@ skipping 632 matching lines @@
   if (focused_frame->LocalFrameRoot() != MainFrameImpl()->GetFrame())
     return nullptr;
   return focused_frame;
 }
 
 LocalFrame* WebViewImpl::FocusedLocalFrameAvailableForIme() const {
   return ime_accept_events_ ? FocusedLocalFrameInWidget() : nullptr;
 }
 
 }  // namespace blink