Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc

Issue 2894023002: [subresource_filter] Move activation computation to the SB throttle (Closed)
Patch Set: shivanisha review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/subresource_filter/chrome_subresource_filter_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc
index 150b26fae8c4437dd2c618b240936045a9df5e6e..729007106e14d256275fdd77d267208281a967c9 100644
--- a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc
@@ -6,11 +6,12 @@
#include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
#include "components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h"
+#include "components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.h"
#include "components/subresource_filter/core/common/activation_decision.h"
#include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"
using subresource_filter::ContentSubresourceFilterDriverFactory;
-
+using subresource_filter::SubresourceFilterSafeBrowsingActivationThrottle;
using ActivationDecision = subresource_filter::ActivationDecision;
namespace internal {
@@ -123,9 +124,8 @@ void LogActivationDecisionMetrics(content::NavigationHandle* navigation_handle,
static_cast<int>(decision),
static_cast<int>(ActivationDecision::ACTIVATION_DECISION_MAX));
- if (ContentSubresourceFilterDriverFactory::NavigationIsPageReload(
- navigation_handle->GetURL(), navigation_handle->GetReferrer(),
- navigation_handle->GetPageTransition())) {
+ if (SubresourceFilterSafeBrowsingActivationThrottle::NavigationIsPageReload(
+ navigation_handle)) {
UMA_HISTOGRAM_ENUMERATION(
internal::kHistogramSubresourceFilterActivationDecisionReload,
static_cast<int>(decision),
« no previous file with comments | « no previous file | chrome/browser/subresource_filter/chrome_subresource_filter_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698