Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: net/nqe/throughput_analyzer.h

Issue 2893933004: Throughput: Change the min number of requests in flight required (Closed)
Patch Set: ryansturm comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/nqe/network_quality_estimator_params.cc ('k') | net/nqe/throughput_analyzer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/throughput_analyzer.h
diff --git a/net/nqe/throughput_analyzer.h b/net/nqe/throughput_analyzer.h
index e94102ba6f4c280c3a0030f335b916ca3be8b443..d83e9db0a4f5dfbb8cae2058bba7ab5f2a7787a1 100644
--- a/net/nqe/throughput_analyzer.h
+++ b/net/nqe/throughput_analyzer.h
@@ -31,6 +31,8 @@ namespace nqe {
namespace internal {
+class NetworkQualityEstimatorParams;
+
// Makes throughput observations. Polls NetworkActivityMonitor
// (TrafficStats on Android) to count number of bits received over throughput
// observation windows in accordance with the following rules:
@@ -55,6 +57,7 @@ class NET_EXPORT_PRIVATE ThroughputAnalyzer {
// estimation.
// Virtualized for testing.
ThroughputAnalyzer(
+ const NetworkQualityEstimatorParams* params,
scoped_refptr<base::SingleThreadTaskRunner> task_runner,
ThroughputObservationCallback throughput_observation_callback,
bool use_local_host_requests_for_tests,
@@ -106,7 +109,7 @@ class NET_EXPORT_PRIVATE ThroughputAnalyzer {
// tracking throughput. A throughput observation can be taken only if the
// time-window is currently active, and enough bytes have accumulated in
// that window. |downstream_kbps| should not be null.
- bool MayBeGetThroughputObservation(int32_t* downstream_kbps);
+ bool MaybeGetThroughputObservation(int32_t* downstream_kbps);
// Starts the throughput observation window that keeps track of network
// bytes if the following conditions are true:
@@ -133,6 +136,7 @@ class NET_EXPORT_PRIVATE ThroughputAnalyzer {
// do not exceed their capacities.
void BoundRequestsSize();
+ const NetworkQualityEstimatorParams* params_;
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
// Called every time a new throughput observation is available.
« no previous file with comments | « net/nqe/network_quality_estimator_params.cc ('k') | net/nqe/throughput_analyzer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698