Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: net/nqe/network_quality_estimator_params.h

Issue 2893933004: Throughput: Change the min number of requests in flight required (Closed)
Patch Set: ps Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_quality_estimator_params.h
diff --git a/net/nqe/network_quality_estimator_params.h b/net/nqe/network_quality_estimator_params.h
index 5c279e1b39d5b615c9fe5db630f3536c9353ecc8..3a30ad6a798a6f6567ebdaada791e62ad1559350 100644
--- a/net/nqe/network_quality_estimator_params.h
+++ b/net/nqe/network_quality_estimator_params.h
@@ -60,6 +60,12 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimatorParams {
// Returns the threshold for effective connection type |type|.
const NetworkQuality& ConnectionThreshold(EffectiveConnectionType type) const;
+ // Returns the minimum number of requests in-flight before the throughput
RyanSturm 2017/05/22 20:14:40 nit: I don't like this phrasing. I'm struggling to
tbansal1 2017/05/22 22:51:55 Done.
+ // observation can be taken.
+ size_t throughput_min_requests_in_flight() const {
+ return throughput_min_requests_in_flight_;
+ }
+
// Returns the weight multiplier per second, which represents the factor by
// which the weight of an observation reduces every second.
double weight_multiplier_per_second() const {
@@ -103,6 +109,7 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimatorParams {
// NetworkQualityEstimator field trial.
const std::map<std::string, std::string> params_;
+ const size_t throughput_min_requests_in_flight_;
const double weight_multiplier_per_second_;
const double weight_multiplier_per_dbm_;
const double correlation_uma_logging_probability_;

Powered by Google App Engine
This is Rietveld 408576698