Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 289393002: Remove --no-js-randomness. Only used by perftracker, which is dead. (Closed)

Created:
6 years, 7 months ago by Peter Kasting
Modified:
6 years, 7 months ago
Reviewers:
Nico, tonyg
CC:
chromium-reviews, tonyg
Visibility:
Public.

Description

Remove --no-js-randomness. Only used by perftracker, which is dead. The V8 team signed off on removing this as well. BUG=361460 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271444

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +1 line, -2 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
Peter Kasting
6 years, 7 months ago (2014-05-19 14:33:14 UTC) #1
tonyg
lgtm https://codereview.chromium.org/289393002/diff/1/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): https://codereview.chromium.org/289393002/diff/1/chrome/renderer/chrome_content_renderer_client.cc#newcode306 chrome/renderer/chrome_content_renderer_client.cc:306: command_line->HasSwitch(switches::kRecordMode)) { I think these and the entire ...
6 years, 7 months ago (2014-05-19 14:38:04 UTC) #2
Peter Kasting
https://codereview.chromium.org/289393002/diff/1/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): https://codereview.chromium.org/289393002/diff/1/chrome/renderer/chrome_content_renderer_client.cc#newcode306 chrome/renderer/chrome_content_renderer_client.cc:306: command_line->HasSwitch(switches::kRecordMode)) { On 2014/05/19 14:38:04, tonyg wrote: > I ...
6 years, 7 months ago (2014-05-19 14:42:43 UTC) #3
Peter Kasting
(Nico, I'm still going to wait for your OWNERS signoff so I can CQ+ this.)
6 years, 7 months ago (2014-05-19 17:59:38 UTC) #4
Nico
lgtm On 2014/05/19 17:59:38, Peter Kasting wrote: > (Nico, I'm still going to wait for ...
6 years, 7 months ago (2014-05-19 18:00:44 UTC) #5
Peter Kasting
The CQ bit was checked by pkasting@chromium.org
6 years, 7 months ago (2014-05-19 18:06:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/289393002/1
6 years, 7 months ago (2014-05-19 18:07:41 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 19:05:38 UTC) #8
Message was sent while issue was closed.
Change committed as 271444

Powered by Google App Engine
This is Rietveld 408576698