Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: sdk/lib/async/stream_impl.dart

Issue 2893893002: Use generic functions in zones. (Closed)
Patch Set: Change synchronous error handling of `runZoned`. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/async/stream_impl.dart
diff --git a/sdk/lib/async/stream_impl.dart b/sdk/lib/async/stream_impl.dart
index 7337756f7e5008cabb5612fb256522af5aa1194d..2c39dd34287f32d42f6add5cb982e661a22be386 100644
--- a/sdk/lib/async/stream_impl.dart
+++ b/sdk/lib/async/stream_impl.dart
@@ -332,7 +332,7 @@ class _BufferingStreamSubscription<T>
_checkState(wasInputPaused);
}
- void _sendError(var error, StackTrace stackTrace) {
+ void _sendError(Object error, StackTrace stackTrace) {
assert(!_isCanceled);
assert(!_isPaused);
assert(!_inCallback);
@@ -345,12 +345,11 @@ class _BufferingStreamSubscription<T>
_state |= _STATE_IN_CALLBACK;
// TODO(floitsch): this dynamic should be 'void'.
if (_onError is ZoneBinaryCallback<dynamic, Object, StackTrace>) {
- ZoneBinaryCallback<dynamic, Object, StackTrace> errorCallback = _onError
- as Object/*=ZoneBinaryCallback<dynamic, Object, StackTrace>*/;
+ ZoneBinaryCallback<dynamic, Object, StackTrace> errorCallback =
+ _onError;
_zone.runBinaryGuarded(errorCallback, error, stackTrace);
} else {
- _zone.runUnaryGuarded<dynamic, Object>(
- _onError as Object/*=ZoneUnaryCallback<dynamic, Object>*/, error);
+ _zone.runUnaryGuarded<Object>(_onError, error);
}
_state &= ~_STATE_IN_CALLBACK;
}

Powered by Google App Engine
This is Rietveld 408576698