Use generic functions in zones.

sdk/lib/async/zone.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.async;
 
 typedef R ZoneCallback<R>();
 typedef R ZoneUnaryCallback<R, T>(T arg);
 typedef R ZoneBinaryCallback<R, T1, T2>(T1 arg1, T2 arg2);
 
-// TODO(floitsch): we are abusing generic typedefs as typedefs for generic
-// functions.
-/*ABUSE*/
-typedef R HandleUncaughtErrorHandler<R>(
-    Zone self, ZoneDelegate parent, Zone zone, error, StackTrace stackTrace);
-/*ABUSE*/
-typedef R RunHandler<R>(Zone self, ZoneDelegate parent, Zone zone, R f());
-/*ABUSE*/
-typedef R RunUnaryHandler<R, T>(
-    Zone self, ZoneDelegate parent, Zone zone, R f(T arg), T arg);
-/*ABUSE*/
-typedef R RunBinaryHandler<R, T1, T2>(Zone self, ZoneDelegate parent, Zone zone,
-    R f(T1 arg1, T2 arg2), T1 arg1, T2 arg2);
-/*ABUSE*/
-typedef ZoneCallback<R> RegisterCallbackHandler<R>(
-    Zone self, ZoneDelegate parent, Zone zone, R f());
-/*ABUSE*/
-typedef ZoneUnaryCallback<R, T> RegisterUnaryCallbackHandler<R, T>(
-    Zone self, ZoneDelegate parent, Zone zone, R f(T arg));
-/*ABUSE*/
-typedef ZoneBinaryCallback<R, T1, T2> RegisterBinaryCallbackHandler<R, T1, T2>(
-    Zone self, ZoneDelegate parent, Zone zone, R f(T1 arg1, T2 arg2));
+typedef HandleUncaughtErrorHandler = void Function(Zone self,
+    ZoneDelegate parent, Zone zone, Object error, StackTrace stackTrace);
+typedef RunHandler = R Function<R>(
+    Zone self, ZoneDelegate parent, Zone zone, R Function() f);
+typedef RunUnaryHandler = R Function<R, T>(
+    Zone self, ZoneDelegate parent, Zone zone, R Function(T arg) f, T arg);
+typedef RunBinaryHandler = R Function<R, T1, T2>(Zone self, ZoneDelegate parent,
+    Zone zone, R Function(T1 arg1, T2 arg2) f, T1 arg1, T2 arg2);
+typedef RegisterCallbackHandler = ZoneCallback<R> Function<R>(
+    Zone self, ZoneDelegate parent, Zone zone, R Function() f);
+typedef RegisterUnaryCallbackHandler = ZoneUnaryCallback<R, T> Function<R, T>(
+    Zone self, ZoneDelegate parent, Zone zone, R Function(T arg) f);
+typedef RegisterBinaryCallbackHandler
+    = ZoneBinaryCallback<R, T1, T2> Function<R, T1, T2>(Zone self,
+        ZoneDelegate parent, Zone zone, R Function(T1 arg1, T2 arg2) f);
 typedef AsyncError ErrorCallbackHandler(Zone self, ZoneDelegate parent,
     Zone zone, Object error, StackTrace stackTrace);
 typedef void ScheduleMicrotaskHandler(
     Zone self, ZoneDelegate parent, Zone zone, void f());
 typedef Timer CreateTimerHandler(
     Zone self, ZoneDelegate parent, Zone zone, Duration duration, void f());
 typedef Timer CreatePeriodicTimerHandler(Zone self, ZoneDelegate parent,
     Zone zone, Duration period, void f(Timer timer));
 typedef void PrintHandler(
     Zone self, ZoneDelegate parent, Zone zone, String line);
@@ skipping 159 matching lines @@
  *
  * While zones have access to their parent zone (through [Zone.parent]) it is
  * recommended to call the methods on the provided parent delegate for two
  * reasons:
  * 1. the delegate methods take an additional `zone` argument which is the
  *   zone the action has been initiated in.
  * 2. delegate calls are more efficient, since the implementation knows how
  *   to skip zones that would just delegate to their parents.
  */
 abstract class ZoneDelegate {
-  R handleUncaughtError<R>(Zone zone, error, StackTrace stackTrace);
+  void handleUncaughtError(Zone zone, error, StackTrace stackTrace);
   R run<R>(Zone zone, R f());
   R runUnary<R, T>(Zone zone, R f(T arg), T arg);
   R runBinary<R, T1, T2>(Zone zone, R f(T1 arg1, T2 arg2), T1 arg1, T2 arg2);
   ZoneCallback<R> registerCallback<R>(Zone zone, R f());
   ZoneUnaryCallback<R, T> registerUnaryCallback<R, T>(Zone zone, R f(T arg));
   ZoneBinaryCallback<R, T1, T2> registerBinaryCallback<R, T1, T2>(
       Zone zone, R f(T1 arg1, T2 arg2));
   AsyncError errorCallback(Zone zone, Object error, StackTrace stackTrace);
   void scheduleMicrotask(Zone zone, void f());
   Timer createTimer(Zone zone, Duration duration, void f());
@@ skipping 33 matching lines @@
  *   also remembers the current zone so that it can later run the callback in
  *   that zone.
  * 2. At a later point the registered callback is run in the remembered zone.
  *
  * This is all handled internally by the platform code and most users don't need
  * to worry about it. However, developers of new asynchronous operations,
  * provided by the underlying system or through native extensions, must follow
  * the protocol to be zone compatible.
  *
  * For convenience, zones provide [bindCallback] (and the corresponding
- * [bindUnaryCallback] or [bindBinaryCallback]) to make it easier to respect the
- * zone contract: these functions first invoke the corresponding `register`
+ * [bindUnaryCallback] and [bindBinaryCallback]) to make it easier to respect
+ * the zone contract: these functions first invoke the corresponding `register`
  * functions and then wrap the returned function so that it runs in the current
  * zone when it is later asynchronously invoked.
+ *
+ * Similarly, zones provide [bindCallbackGuarded] (and the corresponding
+ * [bindUnaryCallbackGuarded] and [bindBinaryCallbackGuarded]), when the
+ * callback should be invoked through [Zone.runGuarded].
  */
 abstract class Zone {
   // Private constructor so that it is not possible instantiate a Zone class.
   Zone._();
 
   /**
    * The root zone.
    *
    * All isolate entry functions (`main` or spawned functions) start running in
    * the root zone (that is, [Zone.current] is identical to [Zone.ROOT] when the
@@ skipping 25 matching lines @@
    *   chains, but for which no child registered an error handler.
    *   Most asynchronous classes, like [Future] or [Stream] push errors to their
    *   listeners. Errors are propagated this way until either a listener handles
    *   the error (for example with [Future.catchError]), or no listener is
    *   available anymore. In the latter case, futures and streams invoke the
    *   zone's [handleUncaughtError].
    *
    * By default, when handled by the root zone, uncaught asynchronous errors are
    * treated like uncaught synchronous exceptions.
    */
-  R handleUncaughtError<R>(error, StackTrace stackTrace);
+  void handleUncaughtError(error, StackTrace stackTrace);
 
   /**
    * The parent zone of the this zone.
    *
    * Is `null` if `this` is the [ROOT] zone.
    *
    * Zones are created by [fork] on an existing zone, or by [runZoned] which
    * forks the [current] zone. The new zone's parent zone is the zone it was
    * forked from.
    */
@@ skipping 105 matching lines @@
   R runBinary<R, T1, T2>(
       R action(T1 argument1, T2 argument2), T1 argument1, T2 argument2);
 
   /**
    * Executes the given [action] in this zone and catches synchronous
    * errors.
    *
    * This function is equivalent to:
    * ```
    * try {
-   *   return this.run(action);
+   *   this.run(action);
    * } catch (e, s) {
-   *   return this.handleUncaughtError(e, s);
+   *   this.handleUncaughtError(e, s);
    * }
    * ```
    *
    * See [run].
    */
-  R runGuarded<R>(R action());
+  void runGuarded(void action());
 
   /**
    * Executes the given [action] with [argument] in this zone and
    * catches synchronous errors.
    *
    * See [runGuarded].
    */
-  R runUnaryGuarded<R, T>(R action(T argument), T argument);
+  void runUnaryGuarded<T>(void action(T argument), T argument);
 
   /**
    * Executes the given [action] with [argument1] and [argument2] in this
    * zone and catches synchronous errors.
    *
    * See [runGuarded].
    */
-  R runBinaryGuarded<R, T1, T2>(
-      R action(T1 argument1, T2 argument2), T1 argument1, T2 argument2);
+  void runBinaryGuarded<T1, T2>(
+      void action(T1 argument1, T2 argument2), T1 argument1, T2 argument2);
 
   /**
    * Registers the given callback in this zone.
    *
    * When implementing an asynchronous primitive that uses callbacks, the
    * callback must be registered using [registerCallback] at the point where the
    * user provides the callback. This allows zones to record other information
    * that they need at the same time, perhaps even wrapping the callback, so
    * that the callback is prepared when it is later run in the same zones
    * (using [run]). For example, a zone may decide
@@ skipping 17 matching lines @@
 
   /**
    * Registers the given callback in this zone.
    *
    * Similar to [registerCallback] but with a unary callback.
    */
   ZoneBinaryCallback<R, T1, T2> registerBinaryCallback<R, T1, T2>(
       R callback(T1 arg1, T2 arg2));
 
   /**
+   *  Registers the provided [callback] and returns a function that will
+   *  execute in this zone.
+   *
    *  Equivalent to:
    *
-   *      ZoneCallback registered = this.registerCallback(action);
-   *      if (runGuarded) return () => this.runGuarded(registered);
+   *      ZoneCallback registered = this.registerCallback(callback);
    *      return () => this.run(registered);
    *
    */
-  ZoneCallback<R> bindCallback<R>(R action(), {bool runGuarded: true});
+  ZoneCallback<R> bindCallback<R>(R callback());
 
   /**
+   *  Registers the provided [callback] and returns a function that will
+   *  execute in this zone.
+   *
    *  Equivalent to:
    *
-   *      ZoneCallback registered = this.registerUnaryCallback(action);
-   *      if (runGuarded) return (arg) => this.runUnaryGuarded(registered, arg);
+   *      ZoneCallback registered = this.registerUnaryCallback(callback);
    *      return (arg) => thin.runUnary(registered, arg);
    */
-  ZoneUnaryCallback<R, T> bindUnaryCallback<R, T>(R action(T argument),
-      {bool runGuarded: true});
+  ZoneUnaryCallback<R, T> bindUnaryCallback<R, T>(R callback(T argument));
 
   /**
+   *  Registers the provided [callback] and returns a function that will
+   *  execute in this zone.
+   *
    *  Equivalent to:
    *
-   *      ZoneCallback registered = registerBinaryCallback(action);
-   *      if (runGuarded) {
-   *        return (arg1, arg2) => this.runBinaryGuarded(registered, arg);
-   *      }
+   *      ZoneCallback registered = registerBinaryCallback(callback);
    *      return (arg1, arg2) => thin.runBinary(registered, arg1, arg2);
    */
   ZoneBinaryCallback<R, T1, T2> bindBinaryCallback<R, T1, T2>(
-      R action(T1 argument1, T2 argument2),
-      {bool runGuarded: true});
+      R callback(T1 argument1, T2 argument2));
+
+  /**
+   * Registers the provided [callback] and returns a function that will
+   * execute in this zone.
+   *
+   * When the function executes, errors are caught and treated as uncaught
+   * errors.
+   *
+   * Equivalent to:
+   *
+   *     ZoneCallback registered = this.registerCallback(callback);
+   *     return () => this.runGuarded(registered);
+   *
+   */
+  void Function() bindCallbackGuarded(void callback());
+
+  /**
+   * Registers the provided [callback] and returns a function that will
+   * execute in this zone.
+   *
+   * When the function executes, errors are caught and treated as uncaught
+   * errors.
+   *
+   * Equivalent to:
+   *
+   *     ZoneCallback registered = this.registerUnaryCallback(callback);
+   *     return (arg) => this.runUnaryGuarded(registered, arg);
+   */
+  void Function(T) bindUnaryCallbackGuarded<T>(void callback(T argument));
+
+  /**
+   *  Registers the provided [callback] and returns a function that will
+   *  execute in this zone.
+   *
+   *  Equivalent to:
+   *
+   *      ZoneCallback registered = registerBinaryCallback(callback);
+   *      return (arg1, arg2) => this.runBinaryGuarded(registered, arg1, arg2);
+   */
+  void Function(T1, T2) bindBinaryCallbackGuarded<T1, T2>(
+      void callback(T1 argument1, T2 argument2));
 
   /**
    * Intercepts errors when added programmatically to a `Future` or `Stream`.
    *
    * When calling [Completer.completeError], [StreamController.addError],
    * or some [Future] constructors, the current zone is allowed to intercept
    * and replace the error.
    *
    * Future constructors invoke this function when the error is received
    * directly, for example with [Future.error], or when the error is caught
@@ skipping 13 matching lines @@
    * Custom zones may intercept this operation.
    *
    * Implementations of a new asynchronous primitive that converts synchronous
    * errors to asynchronous errors rarely need to invoke [errorCallback], since
    * errors are usually reported through future completers or stream
    * controllers.
    */
   AsyncError errorCallback(Object error, StackTrace stackTrace);
 
   /**
-   * Runs [action] asynchronously in this zone.
+   * Runs [callback] asynchronously in this zone.
    *
    * The global `scheduleMicrotask` delegates to the current zone's
    * [scheduleMicrotask]. The root zone's implementation interacts with the
    * underlying system to schedule the given callback as a microtask.
    *
    * Custom zones may intercept this operation (for example to wrap the given
-   * callback [action]).
+   * [callback]).
    */
-  void scheduleMicrotask(void action());
+  void scheduleMicrotask(void callback());
 
   /**
    * Creates a Timer where the callback is executed in this zone.
    */
   Timer createTimer(Duration duration, void callback());
 
   /**
    * Creates a periodic Timer where the callback is executed in this zone.
    */
   Timer createPeriodicTimer(Duration period, void callback(Timer timer));
@@ skipping 61 matching lines @@
 ZoneDelegate _parentDelegate(_Zone zone) {
   if (zone.parent == null) return null;
   return zone.parent._delegate;
 }
 
 class _ZoneDelegate implements ZoneDelegate {
   final _Zone _delegationTarget;
 
   _ZoneDelegate(this._delegationTarget);
 
-  R handleUncaughtError<R>(Zone zone, error, StackTrace stackTrace) {
+  void handleUncaughtError(Zone zone, error, StackTrace stackTrace) {
     var implementation = _delegationTarget._handleUncaughtError;
     _Zone implZone = implementation.zone;
     HandleUncaughtErrorHandler handler = implementation.function;
-    // TODO(floitsch): make this a generic method call on '<R>' once it's
-    // supported. Remove the unnecessary cast.
-    return handler(implZone, _parentDelegate(implZone), zone, error, stackTrace)
-        as Object/*=R*/;
+    return handler(
+        implZone, _parentDelegate(implZone), zone, error, stackTrace);
   }
 
   R run<R>(Zone zone, R f()) {
     var implementation = _delegationTarget._run;
     _Zone implZone = implementation.zone;
     RunHandler handler = implementation.function;
-    // TODO(floitsch): make this a generic method call on '<R>' once it's
-    // supported. Remove the unnecessary cast.
-    return handler(implZone, _parentDelegate(implZone), zone, f)
-        as Object/*=R*/;
+    return handler(implZone, _parentDelegate(implZone), zone, f);
   }
 
   R runUnary<R, T>(Zone zone, R f(T arg), T arg) {
     var implementation = _delegationTarget._runUnary;
     _Zone implZone = implementation.zone;
     RunUnaryHandler handler = implementation.function;
-    // TODO(floitsch): make this a generic method call on '<R, T>' once it's
-    // supported. Remove the unnecessary cast.
-    return handler(implZone, _parentDelegate(implZone), zone, f, arg)
-        as Object/*=R*/;
+    return handler(implZone, _parentDelegate(implZone), zone, f, arg);
   }
 
   R runBinary<R, T1, T2>(Zone zone, R f(T1 arg1, T2 arg2), T1 arg1, T2 arg2) {
     var implementation = _delegationTarget._runBinary;
     _Zone implZone = implementation.zone;
     RunBinaryHandler handler = implementation.function;
-    // TODO(floitsch): make this a generic method call on '<R, T1, T2>' once
-    // it's supported. Remove the unnecessary cast.
-    return handler(implZone, _parentDelegate(implZone), zone, f, arg1, arg2)
-        as Object/*=R*/;
+    return handler(implZone, _parentDelegate(implZone), zone, f, arg1, arg2);
   }
 
   ZoneCallback<R> registerCallback<R>(Zone zone, R f()) {
     var implementation = _delegationTarget._registerCallback;
     _Zone implZone = implementation.zone;
     RegisterCallbackHandler handler = implementation.function;
-    // TODO(floitsch): make this a generic method call on '<R>' once it's
-    // supported. Remove the unnecessary cast.
-    return handler(implZone, _parentDelegate(implZone), zone, f)
-        as Object/*=ZoneCallback<R>*/;
+    return handler(implZone, _parentDelegate(implZone), zone, f);
   }
 
   ZoneUnaryCallback<R, T> registerUnaryCallback<R, T>(Zone zone, R f(T arg)) {
     var implementation = _delegationTarget._registerUnaryCallback;
     _Zone implZone = implementation.zone;
     RegisterUnaryCallbackHandler handler = implementation.function;
-    // TODO(floitsch): make this a generic method call on '<R, T>' once it's
-    // supported. Remove the unnecessary cast.
-    return handler(implZone, _parentDelegate(implZone), zone, f)
-        as Object/*=ZoneUnaryCallback<R, T>*/;
+    return handler(implZone, _parentDelegate(implZone), zone, f);
   }
 
   ZoneBinaryCallback<R, T1, T2> registerBinaryCallback<R, T1, T2>(
       Zone zone, R f(T1 arg1, T2 arg2)) {
     var implementation = _delegationTarget._registerBinaryCallback;
     _Zone implZone = implementation.zone;
     RegisterBinaryCallbackHandler handler = implementation.function;
-    // TODO(floitsch): make this a generic method call on '<R, T1, T2>' once
-    // it's supported. Remove the unnecessary cast.
-    return handler(implZone, _parentDelegate(implZone), zone, f)
-        as Object/*=ZoneBinaryCallback<R, T1, T2>*/;
+    return handler(implZone, _parentDelegate(implZone), zone, f);
   }
 
   AsyncError errorCallback(Zone zone, Object error, StackTrace stackTrace) {
     var implementation = _delegationTarget._errorCallback;
     _Zone implZone = implementation.zone;
     if (identical(implZone, _ROOT_ZONE)) return null;
     ErrorCallbackHandler handler = implementation.function;
     return handler(
         implZone, _parentDelegate(implZone), zone, error, stackTrace);
   }
@@ skipping 34 matching lines @@
         implZone, _parentDelegate(implZone), zone, specification, zoneValues);
   }
 }
 
 /**
  * Base class for Zone implementations.
  */
 abstract class _Zone implements Zone {
   const _Zone();
 
-  _ZoneFunction<RunHandler> get _run;
-  _ZoneFunction<RunUnaryHandler> get _runUnary;
-  _ZoneFunction<RunBinaryHandler> get _runBinary;
-  _ZoneFunction<RegisterCallbackHandler> get _registerCallback;
-  _ZoneFunction<RegisterUnaryCallbackHandler> get _registerUnaryCallback;
-  _ZoneFunction<RegisterBinaryCallbackHandler> get _registerBinaryCallback;
+  // TODO(floitsch): the types of the `_ZoneFunction`s should have a type for
+  // all fields.
+  _ZoneFunction<Function> get _run;
+  _ZoneFunction<Function> get _runUnary;
+  _ZoneFunction<Function> get _runBinary;
+  _ZoneFunction<Function> get _registerCallback;
+  _ZoneFunction<Function> get _registerUnaryCallback;
+  _ZoneFunction<Function> get _registerBinaryCallback;
   _ZoneFunction<ErrorCallbackHandler> get _errorCallback;
   _ZoneFunction<ScheduleMicrotaskHandler> get _scheduleMicrotask;
   _ZoneFunction<CreateTimerHandler> get _createTimer;
   _ZoneFunction<CreatePeriodicTimerHandler> get _createPeriodicTimer;
   _ZoneFunction<PrintHandler> get _print;
   _ZoneFunction<ForkHandler> get _fork;
   _ZoneFunction<HandleUncaughtErrorHandler> get _handleUncaughtError;
   _Zone get parent;
   ZoneDelegate get _delegate;
   Map get _map;
 
   bool inSameErrorZone(Zone otherZone) {
     return identical(this, otherZone) ||
         identical(errorZone, otherZone.errorZone);
   }
 }
 
 class _CustomZone extends _Zone {
   // The actual zone and implementation of each of these
   // inheritable zone functions.
-  _ZoneFunction<RunHandler> _run;
-  _ZoneFunction<RunUnaryHandler> _runUnary;
-  _ZoneFunction<RunBinaryHandler> _runBinary;
-  _ZoneFunction<RegisterCallbackHandler> _registerCallback;
-  _ZoneFunction<RegisterUnaryCallbackHandler> _registerUnaryCallback;
-  _ZoneFunction<RegisterBinaryCallbackHandler> _registerBinaryCallback;
+  // TODO(floitsch): the types of the `_ZoneFunction`s should have a type for
+  // all fields.
+  _ZoneFunction<Function> _run;
+  _ZoneFunction<Function> _runUnary;
+  _ZoneFunction<Function> _runBinary;
+  _ZoneFunction<Function> _registerCallback;
+  _ZoneFunction<Function> _registerUnaryCallback;
+  _ZoneFunction<Function> _registerBinaryCallback;
   _ZoneFunction<ErrorCallbackHandler> _errorCallback;
   _ZoneFunction<ScheduleMicrotaskHandler> _scheduleMicrotask;
   _ZoneFunction<CreateTimerHandler> _createTimer;
   _ZoneFunction<CreatePeriodicTimerHandler> _createPeriodicTimer;
   _ZoneFunction<PrintHandler> _print;
   _ZoneFunction<ForkHandler> _fork;
   _ZoneFunction<HandleUncaughtErrorHandler> _handleUncaughtError;
 
   // A cached delegate to this zone.
   ZoneDelegate _delegateCache;
@@ skipping 10 matching lines @@
     if (_delegateCache != null) return _delegateCache;
     _delegateCache = new _ZoneDelegate(this);
     return _delegateCache;
   }
 
   _CustomZone(this.parent, ZoneSpecification specification, this._map) {
     // The root zone will have implementations of all parts of the
     // specification, so it will never try to access the (null) parent.
     // All other zones have a non-null parent.
     _run = (specification.run != null)
-        ? new _ZoneFunction<RunHandler>(this, specification.run)
+        ? new _ZoneFunction<Function>(this, specification.run)
         : parent._run;
     _runUnary = (specification.runUnary != null)
-        ? new _ZoneFunction<RunUnaryHandler>(this, specification.runUnary)
+        ? new _ZoneFunction<Function>(this, specification.runUnary)
         : parent._runUnary;
     _runBinary = (specification.runBinary != null)
-        ? new _ZoneFunction<RunBinaryHandler>(this, specification.runBinary)
+        ? new _ZoneFunction<Function>(this, specification.runBinary)
         : parent._runBinary;
     _registerCallback = (specification.registerCallback != null)
-        ? new _ZoneFunction<RegisterCallbackHandler>(
-            this, specification.registerCallback)
+        ? new _ZoneFunction<Function>(this, specification.registerCallback)
         : parent._registerCallback;
     _registerUnaryCallback = (specification.registerUnaryCallback != null)
-        ? new _ZoneFunction<RegisterUnaryCallbackHandler>(
-            this, specification.registerUnaryCallback)
+        ? new _ZoneFunction<Function>(this, specification.registerUnaryCallback)
         : parent._registerUnaryCallback;
     _registerBinaryCallback = (specification.registerBinaryCallback != null)
-        ? new _ZoneFunction<RegisterBinaryCallbackHandler>(
+        ? new _ZoneFunction<Function>(
             this, specification.registerBinaryCallback)
         : parent._registerBinaryCallback;
     _errorCallback = (specification.errorCallback != null)
         ? new _ZoneFunction<ErrorCallbackHandler>(
             this, specification.errorCallback)
         : parent._errorCallback;
     _scheduleMicrotask = (specification.scheduleMicrotask != null)
         ? new _ZoneFunction<ScheduleMicrotaskHandler>(
             this, specification.scheduleMicrotask)
         : parent._scheduleMicrotask;
@@ skipping 17 matching lines @@
   }
 
   /**
    * The closest error-handling zone.
    *
    * Returns `this` if `this` has an error-handler. Otherwise returns the
    * parent's error-zone.
    */
   Zone get errorZone => _handleUncaughtError.zone;
 
-  R runGuarded<R>(R f()) {
+  void runGuarded(void f()) {
     try {
-      return run(f);
+      run(f);
     } catch (e, s) {
-      return handleUncaughtError(e, s);
+      handleUncaughtError(e, s);
     }
   }
 
-  R runUnaryGuarded<R, T>(R f(T arg), T arg) {
+  void runUnaryGuarded<T>(void f(T arg), T arg) {
     try {
-      return runUnary(f, arg);
+      runUnary(f, arg);
     } catch (e, s) {
-      return handleUncaughtError(e, s);
+      handleUncaughtError(e, s);
     }
   }
 
-  R runBinaryGuarded<R, T1, T2>(R f(T1 arg1, T2 arg2), T1 arg1, T2 arg2) {
+  void runBinaryGuarded<T1, T2>(void f(T1 arg1, T2 arg2), T1 arg1, T2 arg2) {
     try {
-      return runBinary(f, arg1, arg2);
+      runBinary(f, arg1, arg2);
     } catch (e, s) {
-      return handleUncaughtError(e, s);
+      handleUncaughtError(e, s);
     }
   }
 
-  ZoneCallback<R> bindCallback<R>(R f(), {bool runGuarded: true}) {
+  ZoneCallback<R> bindCallback<R>(R f()) {
     var registered = registerCallback(f);
-    if (runGuarded) {
-      return () => this.runGuarded(registered);
-    } else {
-      return () => this.run(registered);
-    }
+    return () => this.run(registered);
   }
 
-  ZoneUnaryCallback<R, T> bindUnaryCallback<R, T>(R f(T arg),
-      {bool runGuarded: true}) {
+  ZoneUnaryCallback<R, T> bindUnaryCallback<R, T>(R f(T arg)) {
     var registered = registerUnaryCallback(f);
-    if (runGuarded) {
-      return (arg) => this.runUnaryGuarded(registered, arg);
-    } else {
-      return (arg) => this.runUnary(registered, arg);
-    }
+    return (arg) => this.runUnary(registered, arg);
   }
 
   ZoneBinaryCallback<R, T1, T2> bindBinaryCallback<R, T1, T2>(
-      R f(T1 arg1, T2 arg2),
-      {bool runGuarded: true}) {
+      R f(T1 arg1, T2 arg2)) {
     var registered = registerBinaryCallback(f);
-    if (runGuarded) {
-      return (arg1, arg2) => this.runBinaryGuarded(registered, arg1, arg2);
-    } else {
-      return (arg1, arg2) => this.runBinary(registered, arg1, arg2);
-    }
+    return (arg1, arg2) => this.runBinary(registered, arg1, arg2);
+  }
+
+  void Function() bindCallbackGuarded(void f()) {
+    var registered = registerCallback(f);
+    return () => this.runGuarded(registered);
+  }
+
+  void Function(T) bindUnaryCallbackGuarded<T>(void f(T arg)) {
+    var registered = registerUnaryCallback(f);
+    return (arg) => this.runUnaryGuarded(registered, arg);
+  }
+
+  void Function(T1, T2) bindBinaryCallbackGuarded<T1, T2>(
+      void f(T1 arg1, T2 arg2)) {
+    var registered = registerBinaryCallback(f);
+    return (arg1, arg2) => this.runBinaryGuarded(registered, arg1, arg2);
   }
 
   operator [](Object key) {
     var result = _map[key];
     if (result != null || _map.containsKey(key)) return result;
     // If we are not the root zone, look up in the parent zone.
     if (parent != null) {
       // We do not optimize for repeatedly looking up a key which isn't
       // there. That would require storing the key and keeping it alive.
       // Copying the key/value from the parent does not keep any new values
       // alive.
       var value = parent[key];
       if (value != null) {
         _map[key] = value;
       }
       return value;
     }
     assert(this == _ROOT_ZONE);
     return null;
   }
 
   // Methods that can be customized by the zone specification.
 
-  R handleUncaughtError<R>(error, StackTrace stackTrace) {
+  void handleUncaughtError(error, StackTrace stackTrace) {
     var implementation = this._handleUncaughtError;
     assert(implementation != null);
     ZoneDelegate parentDelegate = _parentDelegate(implementation.zone);
     HandleUncaughtErrorHandler handler = implementation.function;
-    // TODO(floitsch): make this a generic method call on '<R>' once it's
-    // supported. Remove the unnecessary cast.
-    return handler(implementation.zone, parentDelegate, this, error, stackTrace)
-        as Object/*=R*/;
+    return handler(
+        implementation.zone, parentDelegate, this, error, stackTrace);
   }
 
   Zone fork({ZoneSpecification specification, Map zoneValues}) {
     var implementation = this._fork;
     assert(implementation != null);
     ZoneDelegate parentDelegate = _parentDelegate(implementation.zone);
     ForkHandler handler = implementation.function;
     return handler(
         implementation.zone, parentDelegate, this, specification, zoneValues);
   }
 
   R run<R>(R f()) {
     var implementation = this._run;
     assert(implementation != null);
     ZoneDelegate parentDelegate = _parentDelegate(implementation.zone);
     RunHandler handler = implementation.function;
-    // TODO(floitsch): make this a generic method call on '<R>' once it's
-    // supported. Remove the unnecessary cast.
-    return handler(implementation.zone, parentDelegate, this, f)
-        as Object/*=R*/;
+    return handler(implementation.zone, parentDelegate, this, f);
   }
 
   R runUnary<R, T>(R f(T arg), T arg) {
     var implementation = this._runUnary;
     assert(implementation != null);
     ZoneDelegate parentDelegate = _parentDelegate(implementation.zone);
     RunUnaryHandler handler = implementation.function;
-    // TODO(floitsch): make this a generic method call on '<R, T>' once it's
-    // supported. Remove the unnecessary cast.
-    return handler(implementation.zone, parentDelegate, this, f, arg)
-        as Object/*=R*/;
+    return handler(implementation.zone, parentDelegate, this, f, arg);
   }
 
   R runBinary<R, T1, T2>(R f(T1 arg1, T2 arg2), T1 arg1, T2 arg2) {
     var implementation = this._runBinary;
     assert(implementation != null);
     ZoneDelegate parentDelegate = _parentDelegate(implementation.zone);
     RunBinaryHandler handler = implementation.function;
-    // TODO(floitsch): make this a generic method call on '<R, T1, T2>' once
-    // it's supported. Remove the unnecessary cast.
-    return handler(implementation.zone, parentDelegate, this, f, arg1, arg2)
-        as Object/*=R*/;
+    return handler(implementation.zone, parentDelegate, this, f, arg1, arg2);
   }
 
   ZoneCallback<R> registerCallback<R>(R callback()) {
     var implementation = this._registerCallback;
     assert(implementation != null);
     ZoneDelegate parentDelegate = _parentDelegate(implementation.zone);
     RegisterCallbackHandler handler = implementation.function;
-    // TODO(floitsch): make this a generic method call on '<R>' once it's
-    // supported. Remove the unnecessary cast.
-    return handler(implementation.zone, parentDelegate, this, callback)
-        as Object/*=ZoneCallback<R>*/;
+    return handler(implementation.zone, parentDelegate, this, callback);
   }
 
   ZoneUnaryCallback<R, T> registerUnaryCallback<R, T>(R callback(T arg)) {
     var implementation = this._registerUnaryCallback;
     assert(implementation != null);
     ZoneDelegate parentDelegate = _parentDelegate(implementation.zone);
     RegisterUnaryCallbackHandler handler = implementation.function;
-    // TODO(floitsch): make this a generic method call on '<R, T>' once it's
-    // supported. Remove the unnecessary cast.
-    return handler(implementation.zone, parentDelegate, this, callback)
-        as Object/*=ZoneUnaryCallback<R, T>*/;
+    return handler(implementation.zone, parentDelegate, this, callback);
   }
 
   ZoneBinaryCallback<R, T1, T2> registerBinaryCallback<R, T1, T2>(
       R callback(T1 arg1, T2 arg2)) {
     var implementation = this._registerBinaryCallback;
     assert(implementation != null);
     ZoneDelegate parentDelegate = _parentDelegate(implementation.zone);
     RegisterBinaryCallbackHandler handler = implementation.function;
-    // TODO(floitsch): make this a generic method call on '<R, T1, T2>' once
-    // it's supported. Remove the unnecessary cast.
-    return handler(implementation.zone, parentDelegate, this, callback)
-        as Object/*=ZoneBinaryCallback<R, T1, T2>*/;
+    return handler(implementation.zone, parentDelegate, this, callback);
   }
 
   AsyncError errorCallback(Object error, StackTrace stackTrace) {
     var implementation = this._errorCallback;
     assert(implementation != null);
     final Zone implementationZone = implementation.zone;
     if (identical(implementationZone, _ROOT_ZONE)) return null;
     final ZoneDelegate parentDelegate = _parentDelegate(implementationZone);
     ErrorCallbackHandler handler = implementation.function;
     return handler(implementationZone, parentDelegate, this, error, stackTrace);
@@ skipping 25 matching lines @@
 
   void print(String line) {
     var implementation = this._print;
     assert(implementation != null);
     ZoneDelegate parentDelegate = _parentDelegate(implementation.zone);
     PrintHandler handler = implementation.function;
     return handler(implementation.zone, parentDelegate, this, line);
   }
 }
 
-R _rootHandleUncaughtError<R>(
+void _rootHandleUncaughtError(
     Zone self, ZoneDelegate parent, Zone zone, error, StackTrace stackTrace) {
   _schedulePriorityAsyncCallback(() {
     if (error == null) error = new NullThrownError();
     if (stackTrace == null) throw error;
     _rethrow(error, stackTrace);
   });
 }
 
 external void _rethrow(Object error, StackTrace stackTrace);
 
@@ skipping 44 matching lines @@
 
 ZoneBinaryCallback<R, T1, T2> _rootRegisterBinaryCallback<R, T1, T2>(
     Zone self, ZoneDelegate parent, Zone zone, R f(T1 arg1, T2 arg2)) {
   return f;
 }
 
 AsyncError _rootErrorCallback(Zone self, ZoneDelegate parent, Zone zone,
         Object error, StackTrace stackTrace) =>
     null;
 
-void _rootScheduleMicrotask(Zone self, ZoneDelegate parent, Zone zone, f()) {
+void _rootScheduleMicrotask(
+    Zone self, ZoneDelegate parent, Zone zone, void f()) {
   if (!identical(_ROOT_ZONE, zone)) {
     bool hasErrorHandler = !_ROOT_ZONE.inSameErrorZone(zone);
-    f = zone.bindCallback(f, runGuarded: hasErrorHandler);
+    if (hasErrorHandler) {
+      f = zone.bindCallbackGuarded(f);
+    } else {
+      f = zone.bindCallback(f);
+    }
     // Use root zone as event zone if the function is already bound.
     zone = _ROOT_ZONE;
   }
   _scheduleAsyncCallback(f);
 }
 
 Timer _rootCreateTimer(Zone self, ZoneDelegate parent, Zone zone,
     Duration duration, void callback()) {
   if (!identical(_ROOT_ZONE, zone)) {
     callback = zone.bindCallback(callback);
@@ skipping 40 matching lines @@
     }
   } else {
     valueMap = new HashMap.from(zoneValues);
   }
   return new _CustomZone(zone, specification, valueMap);
 }
 
 class _RootZone extends _Zone {
   const _RootZone();
 
-  _ZoneFunction<RunHandler> get _run =>
-      const _ZoneFunction<RunHandler>(_ROOT_ZONE, _rootRun);
-  _ZoneFunction<RunUnaryHandler> get _runUnary =>
-      const _ZoneFunction<RunUnaryHandler>(_ROOT_ZONE, _rootRunUnary);
-  _ZoneFunction<RunBinaryHandler> get _runBinary =>
-      const _ZoneFunction<RunBinaryHandler>(_ROOT_ZONE, _rootRunBinary);
-  _ZoneFunction<RegisterCallbackHandler> get _registerCallback =>
-      const _ZoneFunction<RegisterCallbackHandler>(
-          _ROOT_ZONE, _rootRegisterCallback);
-  _ZoneFunction<RegisterUnaryCallbackHandler> get _registerUnaryCallback =>
-      const _ZoneFunction<RegisterUnaryCallbackHandler>(
-          _ROOT_ZONE, _rootRegisterUnaryCallback);
-  _ZoneFunction<RegisterBinaryCallbackHandler> get _registerBinaryCallback =>
-      const _ZoneFunction<RegisterBinaryCallbackHandler>(
-          _ROOT_ZONE, _rootRegisterBinaryCallback);
+  _ZoneFunction<Function> get _run =>
+      const _ZoneFunction<Function>(_ROOT_ZONE, _rootRun);
+  _ZoneFunction<Function> get _runUnary =>
+      const _ZoneFunction<Function>(_ROOT_ZONE, _rootRunUnary);
+  _ZoneFunction<Function> get _runBinary =>
+      const _ZoneFunction<Function>(_ROOT_ZONE, _rootRunBinary);
+  _ZoneFunction<Function> get _registerCallback =>
+      const _ZoneFunction<Function>(_ROOT_ZONE, _rootRegisterCallback);
+  _ZoneFunction<Function> get _registerUnaryCallback =>
+      const _ZoneFunction<Function>(_ROOT_ZONE, _rootRegisterUnaryCallback);
+  _ZoneFunction<Function> get _registerBinaryCallback =>
+      const _ZoneFunction<Function>(_ROOT_ZONE, _rootRegisterBinaryCallback);
   _ZoneFunction<ErrorCallbackHandler> get _errorCallback =>
       const _ZoneFunction<ErrorCallbackHandler>(_ROOT_ZONE, _rootErrorCallback);
   _ZoneFunction<ScheduleMicrotaskHandler> get _scheduleMicrotask =>
       const _ZoneFunction<ScheduleMicrotaskHandler>(
           _ROOT_ZONE, _rootScheduleMicrotask);
   _ZoneFunction<CreateTimerHandler> get _createTimer =>
       const _ZoneFunction<CreateTimerHandler>(_ROOT_ZONE, _rootCreateTimer);
   _ZoneFunction<CreatePeriodicTimerHandler> get _createPeriodicTimer =>
       const _ZoneFunction<CreatePeriodicTimerHandler>(
           _ROOT_ZONE, _rootCreatePeriodicTimer);
@@ skipping 25 matching lines @@
   /**
    * The closest error-handling zone.
    *
    * Returns `this` if `this` has an error-handler. Otherwise returns the
    * parent's error-zone.
    */
   Zone get errorZone => this;
 
   // Zone interface.
 
-  R runGuarded<R>(R f()) {
+  void runGuarded(void f()) {
     try {
       if (identical(_ROOT_ZONE, Zone._current)) {
-        return f();
+        f();
+        return;
       }
-      return _rootRun<R>(null, null, this, f);
+      _rootRun(null, null, this, f);
     } catch (e, s) {
-      return handleUncaughtError<R>(e, s);
+      handleUncaughtError(e, s);
     }
   }
 
-  R runUnaryGuarded<R, T>(R f(T arg), T arg) {
+  void runUnaryGuarded<T>(void f(T arg), T arg) {
     try {
       if (identical(_ROOT_ZONE, Zone._current)) {
-        return f(arg);
+        f(arg);
+        return;
       }
-      return _rootRunUnary<R, T>(null, null, this, f, arg);
+      _rootRunUnary(null, null, this, f, arg);
     } catch (e, s) {
-      return handleUncaughtError<R>(e, s);
+      handleUncaughtError(e, s);
     }
   }
 
-  R runBinaryGuarded<R, T1, T2>(R f(T1 arg1, T2 arg2), T1 arg1, T2 arg2) {
+  void runBinaryGuarded<T1, T2>(void f(T1 arg1, T2 arg2), T1 arg1, T2 arg2) {
     try {
       if (identical(_ROOT_ZONE, Zone._current)) {
-        return f(arg1, arg2);
+        f(arg1, arg2);
+        return;
       }
-      return _rootRunBinary<R, T1, T2>(null, null, this, f, arg1, arg2);
+      _rootRunBinary(null, null, this, f, arg1, arg2);
     } catch (e, s) {
-      return handleUncaughtError<R>(e, s);
+      handleUncaughtError(e, s);
     }
   }
 
-  ZoneCallback<R> bindCallback<R>(R f(), {bool runGuarded: true}) {
-    if (runGuarded) {
-      return () => this.runGuarded<R>(f);
-    } else {
-      return () => this.run<R>(f);
-    }
+  ZoneCallback<R> bindCallback<R>(R f()) {
+    return () => this.run<R>(f);
   }
 
-  ZoneUnaryCallback<R, T> bindUnaryCallback<R, T>(R f(T arg),
-      {bool runGuarded: true}) {
-    if (runGuarded) {
-      return (arg) => this.runUnaryGuarded<R, T>(f, arg);
-    } else {
-      return (arg) => this.runUnary<R, T>(f, arg);
-    }
+  ZoneUnaryCallback<R, T> bindUnaryCallback<R, T>(R f(T arg)) {
+    return (arg) => this.runUnary<R, T>(f, arg);
   }
 
   ZoneBinaryCallback<R, T1, T2> bindBinaryCallback<R, T1, T2>(
-      R f(T1 arg1, T2 arg2),
-      {bool runGuarded: true}) {
-    if (runGuarded) {
-      return (arg1, arg2) => this.runBinaryGuarded<R, T1, T2>(f, arg1, arg2);
-    } else {
-      return (arg1, arg2) => this.runBinary<R, T1, T2>(f, arg1, arg2);
-    }
+      R f(T1 arg1, T2 arg2)) {
+    return (arg1, arg2) => this.runBinary<R, T1, T2>(f, arg1, arg2);
+  }
+
+  void Function() bindCallbackGuarded(void f()) {
+    return () => this.runGuarded(f);
+  }
+
+  void Function(T) bindUnaryCallbackGuarded<T>(void f(T arg)) {
+    return (arg) => this.runUnaryGuarded(f, arg);
+  }
+
+  void Function(T1, T2) bindBinaryCallbackGuarded<T1, T2>(
+      void f(T1 arg1, T2 arg2)) {
+    return (arg1, arg2) => this.runBinaryGuarded(f, arg1, arg2);
   }
 
   operator [](Object key) => null;
 
   // Methods that can be customized by the zone specification.
 
-  R handleUncaughtError<R>(error, StackTrace stackTrace) {
-    return _rootHandleUncaughtError(null, null, this, error, stackTrace);
+  void handleUncaughtError(error, StackTrace stackTrace) {
+    _rootHandleUncaughtError(null, null, this, error, stackTrace);
   }
 
   Zone fork({ZoneSpecification specification, Map zoneValues}) {
     return _rootFork(null, null, this, specification, zoneValues);
   }
 
   R run<R>(R f()) {
     if (identical(Zone._current, _ROOT_ZONE)) return f();
     return _rootRun(null, null, this, f);
   }
@@ skipping 33 matching lines @@
   void print(String line) {
     printToConsole(line);
   }
 }
 
 const _ROOT_ZONE = const _RootZone();
 
 /**
  * Runs [body] in its own zone.
  *
+ * Returns the result of invoking [body].
+ *
  * If [onError] is non-null the zone is considered an error zone. All uncaught
  * errors, synchronous or asynchronous, in the zone are caught and handled
- * by the callback.
+ * by the callback. When the error is synchronous, throwing in the [onError]
+ * handler, leads to a synchronous exception.
+ *
+ * Returns `null` when [body] threw, and a provided [onError] function completed
+ * without throwing.
  *
  * Errors may never cross error-zone boundaries. This is intuitive for leaving
  * a zone, but it also applies for errors that would enter an error-zone.
  * Errors that try to cross error-zone boundaries are considered uncaught.
  *
  *     var future = new Future.value(499);
  *     runZoned(() {
  *       future = future.then((_) { throw "error in first error-zone"; });
  *       runZoned(() {
  *         future = future.catchError((e) { print("Never reached!"); });
  *       }, onError: (e) { print("unused error handler"); });
  *     }, onError: (e) { print("catches error of first error-zone."); });
  *
  * Example:
  *
  *     runZoned(() {
  *       new Future(() { throw "asynchronous error"; });
  *     }, onError: print);  // Will print "asynchronous error".
  */
 R runZoned<R>(R body(),
     {Map zoneValues, ZoneSpecification zoneSpecification, Function onError}) {
+  // TODO(floitsch): the return type should be `void` here.
+  if (onError != null &&
+      onError is! ZoneBinaryCallback<dynamic, Object, StackTrace> &&
+      onError is! ZoneUnaryCallback<dynamic, Object>) {
+    throw new ArgumentError("onError callback must take an Object (the error), "
+        "or an Object (the error) and a StackTrace");
+  }
   HandleUncaughtErrorHandler errorHandler;
   if (onError != null) {
     errorHandler = (Zone self, ZoneDelegate parent, Zone zone, error,
         StackTrace stackTrace) {
       try {
-        // TODO(floitsch): the return type should be 'void'.
-        if (onError is ZoneBinaryCallback<dynamic, Object, StackTrace>) {
-          return self.parent.runBinary(onError, error, stackTrace);
+        if (onError is void Function(Object, StackTrace)) {
+          self.parent.runBinary(onError, error, stackTrace);
+          return;
         }
-        return self.parent.runUnary(onError, error);
+        assert(onError is void Function(Object));
+        self.parent.runUnary(onError, error);
       } catch (e, s) {
         if (identical(e, error)) {
-          return parent.handleUncaughtError(zone, error, stackTrace);
+          parent.handleUncaughtError(zone, error, stackTrace);
         } else {
-          return parent.handleUncaughtError(zone, e, s);
+          parent.handleUncaughtError(zone, e, s);
         }
       }
     };
   }
   if (zoneSpecification == null) {
     zoneSpecification =
         new ZoneSpecification(handleUncaughtError: errorHandler);
   } else if (errorHandler != null) {
     zoneSpecification = new ZoneSpecification.from(zoneSpecification,
         handleUncaughtError: errorHandler);
   }
   Zone zone = Zone.current
       .fork(specification: zoneSpecification, zoneValues: zoneValues);
   if (onError != null) {
-    return zone.runGuarded(body);
+    try {
+      return zone.run(body);
+    } catch (e, stackTrace) {
+      if (onError is ZoneBinaryCallback<R, Object, StackTrace>) {
+        zone.runBinary(onError, e, stackTrace);
+        return null;
+      }
+      assert(onError is ZoneUnaryCallback<R, Object>);
+      zone.runUnary(onError, e);
+      return null;
+    }
   } else {
     return zone.run(body);
   }
 }