MD Bookmarks: Enable the delete button in the toolbar overlay

chrome/browser/resources/md_bookmarks/toolbar.js

Index: chrome/browser/resources/md_bookmarks/toolbar.js
diff --git a/chrome/browser/resources/md_bookmarks/toolbar.js b/chrome/browser/resources/md_bookmarks/toolbar.js
index 3ebeb2d5dd6a6f0f1849ec932d1e714daf345ce6..bc489049cb71018eb7188a5c14d84bf35c53a977 100644
--- a/chrome/browser/resources/md_bookmarks/toolbar.js
+++ b/chrome/browser/resources/md_bookmarks/toolbar.js
@@ -99,6 +99,14 @@ Polymer({
   },
 
   /** @private */
+  onDeleteSelectionTap_: function() {
+    var selection = this.getState().selection.items;
+    var commandManager = bookmarks.CommandManager.getInstance();
+    assert(commandManager.canExecute(Command.DELETE, selection));
+    commandManager.handle(Command.DELETE, selection);

[calamity, 2017/05/19 03:54:19]

I do think it's worth having a test _somewhere_ that ensures that this button is
hooked up to the correct functionality.

I don't know if mocking our commandManager like we did for TestStore is overkill
or not, but you can at least locally replace commandManager.handle in a test and
check that the right arguments come through on-tap.

[tsergeant, 2017/05/22 23:51:24]

Okay, I've added a test which will hopefully fulfill the goal of breaking
annoyingly if the button stops working.

I've pulled out a simple TestCommandManager using the existing method to check
if commands fire. I've just stuck it in test_util for now, but I guess I can
move it if you prefer.

+  },
+
+  /** @private */
   onClearSelectionTap_: function() {
     this.dispatch(bookmarks.actions.deselectItems());
   },