MD Bookmarks: Enable the delete button in the toolbar overlay

chrome/browser/resources/md_bookmarks/toolbar.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'bookmarks-toolbar',
 
   behaviors: [
     bookmarks.StoreClient,
   ],
@@ skipping 81 matching lines @@
     this.closeDropdownMenu_();
   },
 
   /** @private */
   onExportTap_: function() {
     chrome.bookmarks.export();
     this.closeDropdownMenu_();
   },
 
   /** @private */
+  onDeleteSelectionTap_: function() {
+    var selection = this.getState().selection.items;
+    var commandManager = bookmarks.CommandManager.getInstance();
+    assert(commandManager.canExecute(Command.DELETE, selection));
+    commandManager.handle(Command.DELETE, selection);

[calamity, 2017/05/19 03:54:19]

I do think it's worth having a test _somewhere_ that ensures that this button is
hooked up to the correct functionality.

I don't know if mocking our commandManager like we did for TestStore is overkill
or not, but you can at least locally replace commandManager.handle in a test and
check that the right arguments come through on-tap.

[tsergeant, 2017/05/22 23:51:24]

Okay, I've added a test which will hopefully fulfill the goal of breaking
annoyingly if the button stops working.

I've pulled out a simple TestCommandManager using the existing method to check
if commands fire. I've just stuck it in test_util for now, but I guess I can
move it if you prefer.

+  },
+
+  /** @private */
   onClearSelectionTap_: function() {
     this.dispatch(bookmarks.actions.deselectItems());
   },
 
   /** @private */
   closeDropdownMenu_: function() {
     var menu = /** @type {!CrActionMenuElement} */ (this.$.dropdown);
     menu.close();
   },
 
@@ skipping 34 matching lines @@
   },
 
   /**
    * @return {string}
    * @private
    */
   getItemsSelectedString_: function() {
     return loadTimeData.getStringF('itemsSelected', this.selectedCount_);
   },
 });