chrome/browser/extensions/api/networking_private/networking_private_event_router_chromeos.cc - Issue 289383004: Merge FavoriteState into NetworkState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_event_router_chromeos.cc

Issue 289383004: Merge FavoriteState into NetworkState (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Elim UpdateManagerProperties, feedback Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_apitest.cc ('k') | chrome/browser/resources/chromeos/network_ui/network_ui.html » ('j') | chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_event_router_chromeos.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_event_router_chromeos.cc b/chrome/browser/extensions/api/networking_private/networking_private_event_router_chromeos.cc

index 73f3a635fa136c657120ee30aeed920f58ccc504..17271424b7d664aaa4e9fd34712a7884aac0f044 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_event_router_chromeos.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_event_router_chromeos.cc

@@ -143,7 +143,8 @@ void NetworkingPrivateEventRouterImpl::StartOrStopListeningForNetworkChanges() {

void NetworkingPrivateEventRouterImpl::NetworkListChanged() {

EventRouter* event_router = EventRouter::Get(profile_);

NetworkStateHandler::NetworkStateList networks;

- NetworkHandler::Get()->network_state_handler()->GetNetworkList(&networks);

+ NetworkHandler::Get()->network_state_handler()->GetVisibleNetworkList(

+ &networks);

if (!event_router->HasEventListener(

api::networking_private::OnNetworkListChanged::kEventName)) {

// TODO(stevenjb): Remove logging once crbug.com/256881 is fixed