Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: chrome/browser/ui/webui/options/preferences_browsertest.cc

Issue 289383004: Merge FavoriteState into NetworkState (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/preferences_browsertest.h" 5 #include "chrome/browser/ui/webui/options/preferences_browsertest.h"
6 6
7 #include <iostream> 7 #include <iostream>
8 #include <sstream> 8 #include <sstream>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 27 matching lines...) Expand all
38 #include "chrome/browser/browser_process.h" 38 #include "chrome/browser/browser_process.h"
39 #include "chrome/browser/chromeos/net/proxy_config_handler.h" 39 #include "chrome/browser/chromeos/net/proxy_config_handler.h"
40 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h" 40 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
41 #include "chrome/browser/chromeos/policy/stub_enterprise_install_attributes.h" 41 #include "chrome/browser/chromeos/policy/stub_enterprise_install_attributes.h"
42 #include "chrome/browser/chromeos/proxy_cros_settings_parser.h" 42 #include "chrome/browser/chromeos/proxy_cros_settings_parser.h"
43 #include "chrome/browser/chromeos/settings/cros_settings.h" 43 #include "chrome/browser/chromeos/settings/cros_settings.h"
44 #include "chrome/browser/prefs/proxy_config_dictionary.h" 44 #include "chrome/browser/prefs/proxy_config_dictionary.h"
45 #include "chromeos/dbus/dbus_thread_manager.h" 45 #include "chromeos/dbus/dbus_thread_manager.h"
46 #include "chromeos/dbus/shill_profile_client.h" 46 #include "chromeos/dbus/shill_profile_client.h"
47 #include "chromeos/dbus/shill_service_client.h" 47 #include "chromeos/dbus/shill_service_client.h"
48 #include "chromeos/network/favorite_state.h"
49 #include "chromeos/network/network_state.h" 48 #include "chromeos/network/network_state.h"
50 #include "chromeos/network/network_state_handler.h" 49 #include "chromeos/network/network_state_handler.h"
51 #include "chromeos/settings/cros_settings_names.h" 50 #include "chromeos/settings/cros_settings_names.h"
52 #include "content/public/test/test_utils.h" 51 #include "content/public/test/test_utils.h"
53 #include "third_party/cros_system_api/dbus/service_constants.h" 52 #include "third_party/cros_system_api/dbus/service_constants.h"
54 #endif 53 #endif
55 54
56 using testing::AllOf; 55 using testing::AllOf;
57 using testing::Mock; 56 using testing::Mock;
58 using testing::Property; 57 using testing::Property;
(...skipping 758 matching lines...) Expand 10 before | Expand all | Expand 10 after
817 virtual void SetUpOnMainThread() OVERRIDE { 816 virtual void SetUpOnMainThread() OVERRIDE {
818 SetupNetworkEnvironment(); 817 SetupNetworkEnvironment();
819 content::RunAllPendingInMessageLoop(); 818 content::RunAllPendingInMessageLoop();
820 819
821 scoped_ptr<base::DictionaryValue> proxy_config_dict( 820 scoped_ptr<base::DictionaryValue> proxy_config_dict(
822 ProxyConfigDictionary::CreateFixedServers("127.0.0.1:8080", 821 ProxyConfigDictionary::CreateFixedServers("127.0.0.1:8080",
823 "*.google.com, 1.2.3.4:22")); 822 "*.google.com, 1.2.3.4:22"));
824 823
825 ProxyConfigDictionary proxy_config(proxy_config_dict.get()); 824 ProxyConfigDictionary proxy_config(proxy_config_dict.get());
826 825
827 const chromeos::FavoriteState* network = GetDefaultFavoriteNetwork(); 826 const chromeos::NetworkState* network = GetDefaultNetwork();
828 ASSERT_TRUE(network); 827 ASSERT_TRUE(network);
829 chromeos::proxy_config::SetProxyConfigForFavoriteNetwork(proxy_config, 828 chromeos::proxy_config::SetProxyConfigForNetwork(proxy_config, *network);
830 *network);
831 829
832 std::string url = base::StringPrintf("%s?network=%s", 830 std::string url = base::StringPrintf("%s?network=%s",
833 chrome::kChromeUIProxySettingsURL, 831 chrome::kChromeUIProxySettingsURL,
834 network->path().c_str()); 832 network->path().c_str());
835 833
836 ui_test_utils::NavigateToURL(browser(), GURL(url)); 834 ui_test_utils::NavigateToURL(browser(), GURL(url));
837 SetUpPrefs(); 835 SetUpPrefs();
838 } 836 }
839 837
840 protected: 838 protected:
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
884 map.Set(policy_name, 882 map.Set(policy_name,
885 policy::POLICY_LEVEL_MANDATORY, 883 policy::POLICY_LEVEL_MANDATORY,
886 scope, 884 scope,
887 new base::StringValue(onc_policy), 885 new base::StringValue(onc_policy),
888 NULL); 886 NULL);
889 policy_provider_.UpdateChromePolicy(map); 887 policy_provider_.UpdateChromePolicy(map);
890 888
891 content::RunAllPendingInMessageLoop(); 889 content::RunAllPendingInMessageLoop();
892 } 890 }
893 891
894 const chromeos::FavoriteState* GetDefaultFavoriteNetwork() { 892 const chromeos::NetworkState* GetDefaultNetwork() {
895 chromeos::NetworkStateHandler* handler = 893 chromeos::NetworkStateHandler* handler =
896 chromeos::NetworkHandler::Get()->network_state_handler(); 894 chromeos::NetworkHandler::Get()->network_state_handler();
897 return handler->DefaultFavoriteNetwork(); 895 return handler->DefaultNetwork();
898 } 896 }
899 897
900 void SetProxyPref(const std::string& name, const base::Value& value) { 898 void SetProxyPref(const std::string& name, const base::Value& value) {
901 std::string type; 899 std::string type;
902 switch (value.GetType()) { 900 switch (value.GetType()) {
903 case base::Value::TYPE_BOOLEAN: 901 case base::Value::TYPE_BOOLEAN:
904 type = "Boolean"; 902 type = "Boolean";
905 break; 903 break;
906 case base::Value::TYPE_INTEGER: 904 case base::Value::TYPE_INTEGER:
907 type = "Integer"; 905 type = "Integer";
908 break; 906 break;
909 case base::Value::TYPE_STRING: 907 case base::Value::TYPE_STRING:
910 type = "String"; 908 type = "String";
911 break; 909 break;
912 default: 910 default:
913 ASSERT_TRUE(false); 911 ASSERT_TRUE(false);
914 } 912 }
915 913
916 std::string observed_json; 914 std::string observed_json;
917 SetPref(name, type, &value, true, &observed_json); 915 SetPref(name, type, &value, true, &observed_json);
918 } 916 }
919 917
920 void VerifyCurrentProxyServer(const std::string& expected_server, 918 void VerifyCurrentProxyServer(const std::string& expected_server,
921 onc::ONCSource expected_source) { 919 onc::ONCSource expected_source) {
922 const chromeos::FavoriteState* network = GetDefaultFavoriteNetwork(); 920 const chromeos::NetworkState* network = GetDefaultNetwork();
923 ASSERT_TRUE(network); 921 ASSERT_TRUE(network);
924 onc::ONCSource actual_source; 922 onc::ONCSource actual_source;
925 scoped_ptr<ProxyConfigDictionary> proxy_dict = 923 scoped_ptr<ProxyConfigDictionary> proxy_dict =
926 chromeos::proxy_config::GetProxyConfigForFavoriteNetwork( 924 chromeos::proxy_config::GetProxyConfigForNetwork(
927 pref_service_, 925 pref_service_,
928 g_browser_process->local_state(), 926 g_browser_process->local_state(),
929 *network, 927 *network,
930 &actual_source); 928 &actual_source);
931 ASSERT_TRUE(proxy_dict); 929 ASSERT_TRUE(proxy_dict);
932 std::string actual_proxy_server; 930 std::string actual_proxy_server;
933 EXPECT_TRUE(proxy_dict->GetProxyServer(&actual_proxy_server)); 931 EXPECT_TRUE(proxy_dict->GetProxyServer(&actual_proxy_server));
934 EXPECT_EQ(expected_server, actual_proxy_server); 932 EXPECT_EQ(expected_server, actual_proxy_server);
935 EXPECT_EQ(expected_source, actual_source); 933 EXPECT_EQ(expected_source, actual_source);
936 } 934 }
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
1084 SetProxyPref(chromeos::kProxyHttpsPort, base::FundamentalValue(2)); 1082 SetProxyPref(chromeos::kProxyHttpsPort, base::FundamentalValue(2));
1085 SetProxyPref(chromeos::kProxyFtpPort, base::FundamentalValue(3)); 1083 SetProxyPref(chromeos::kProxyFtpPort, base::FundamentalValue(3));
1086 SetProxyPref(chromeos::kProxySocksPort, base::FundamentalValue(4)); 1084 SetProxyPref(chromeos::kProxySocksPort, base::FundamentalValue(4));
1087 1085
1088 VerifyCurrentProxyServer( 1086 VerifyCurrentProxyServer(
1089 "http=a.com:1;https=4.3.2.1:2;ftp=c.com:3;socks=socks4://d.com:4", 1087 "http=a.com:1;https=4.3.2.1:2;ftp=c.com:3;socks=socks4://d.com:4",
1090 onc::ONC_SOURCE_NONE); 1088 onc::ONC_SOURCE_NONE);
1091 } 1089 }
1092 1090
1093 #endif 1091 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698