Merge FavoriteState into NetworkState

chromeos/network/network_profile_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_profile_handler.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/strings/string_util.h"
@@ skipping 114 matching lines @@
       continue;
 
     VLOG(2) << "Requesting properties of profile path " << *it << ".";
     DBusThreadManager::Get()->GetShillProfileClient()->GetProperties(
         dbus::ObjectPath(*it),
         base::Bind(&NetworkProfileHandler::GetProfilePropertiesCallback,
                    weak_ptr_factory_.GetWeakPtr(),
                    *it),
         base::Bind(&LogProfileRequestError, *it));
   }
-
-  // When the profile list changes, ServiceCompleteList may also change, so
-  // trigger a Manager update to request the updated list.
-  if (network_state_handler_)
-    network_state_handler_->UpdateManagerProperties();
 }
 
 void NetworkProfileHandler::GetProfilePropertiesCallback(
     const std::string& profile_path,
     const base::DictionaryValue& properties) {
   std::string userhash;
   properties.GetStringWithoutPathExpansion(shill::kUserHashProperty, &userhash);
 
   AddProfile(NetworkProfile(profile_path, userhash));
 }
@@ skipping 43 matching lines @@
   for (NetworkProfileHandler::ProfileList::const_iterator it =
            profiles_.begin();
        it != profiles_.end(); ++it) {
     if (!it->userhash.empty())
       return &*it;
   }
   return NULL;
 }
 
 NetworkProfileHandler::NetworkProfileHandler()
     : network_state_handler_(NULL),

[pneubeck (no reviews), 2014/06/11 12:44:56]

dependency on network_state_handler_ not necessary anymore?

[stevenjb, 2014/06/11 23:31:41]

Done.

       weak_ptr_factory_(this) {
 }
 
 void NetworkProfileHandler::Init(NetworkStateHandler* network_state_handler) {
   network_state_handler_ = network_state_handler;
 
   DBusThreadManager::Get()->GetShillManagerClient()->
       AddPropertyChangedObserver(this);
 
   // Request the initial profile list.
   DBusThreadManager::Get()->GetShillManagerClient()->GetProperties(
       base::Bind(&NetworkProfileHandler::GetManagerPropertiesCallback,
                  weak_ptr_factory_.GetWeakPtr()));
 }
 
 NetworkProfileHandler::~NetworkProfileHandler() {
   DBusThreadManager::Get()->GetShillManagerClient()->
       RemovePropertyChangedObserver(this);
 }
 
 }  // namespace chromeos