third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl - Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)

Patch Set: rename ipc messages Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl

index 15e18ecca676dd712840250d0300de970396c624..2083df69599e407ef737f1169684fd9ea031b7b9 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl

@@ -18,8 +18,6 @@

readonly attribute sequence<PaymentDetailsModifier> modifiers;

readonly attribute DOMString instrumentKey;

- // TODO(gogerald): We should implement this function.

- // Please see: http://crbug.com/720027

- // Promise<WindowClient> openWindow(USVString url);

+ [CallWith=ScriptState] Promise<WindowClient> openWindow(USVString url);

[CallWith=ScriptState, RaisesException] void respondWith(Promise<PaymentResponse> response);

};