Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2211)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)
Patch Set: rename ipc messages Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index 3db1cf81460c105aa474848fddf55db0b01a57ca..bf68c1c019ea1fd903b3884399288c9ff786cb6d 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -631,13 +631,20 @@ void ServiceWorkerContextClient::GetClients(
GetRoutingID(), request_id, options));
}
-void ServiceWorkerContextClient::OpenWindow(
+void ServiceWorkerContextClient::OpenWindowForClients(
const blink::WebURL& url,
std::unique_ptr<blink::WebServiceWorkerClientCallbacks> callbacks) {
DCHECK(callbacks);
int request_id = context_->client_callbacks.Add(std::move(callbacks));
- Send(new ServiceWorkerHostMsg_OpenWindow(
- GetRoutingID(), request_id, url));
+ Send(new ServiceWorkerHostMsg_OpenNewTab(GetRoutingID(), request_id, url));
+}
+
+void ServiceWorkerContextClient::OpenWindowForPaymentHandler(
+ const blink::WebURL& url,
+ std::unique_ptr<blink::WebServiceWorkerClientCallbacks> callbacks) {
+ DCHECK(callbacks);
+ int request_id = context_->client_callbacks.Add(std::move(callbacks));
+ Send(new ServiceWorkerHostMsg_OpenNewPopup(GetRoutingID(), request_id, url));
}
void ServiceWorkerContextClient::SetCachedMetadata(const blink::WebURL& url,

Powered by Google App Engine
This is Rietveld 408576698