Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)
Patch Set: use popup window for payment handler Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index 917fe64bf6a7e3eb4836136bace13309dd57bb6c..ffa9c041b8d6d7052708e9c99f88d429afe760be 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -41,6 +41,7 @@
#include "mojo/public/cpp/bindings/interface_ptr.h"
#include "services/service_manager/public/cpp/interface_provider.h"
#include "third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerEventResult.h"
+#include "ui/base/mojo/window_open_disposition.mojom.h"
#include "url/gurl.h"
#include "url/origin.h"
@@ -584,7 +585,11 @@ class CONTENT_EXPORT ServiceWorkerVersion
void OnGetClients(int request_id,
const ServiceWorkerClientQueryOptions& options);
falken 2017/06/02 07:58:19 // For Clients.openWindow()
gogerald1 2017/06/02 13:21:40 Done.
- void OnOpenWindow(int request_id, GURL url);
+ void OnOpenWindowForClients(int request_id, GURL url);
falken 2017/06/02 07:58:19 // For PaymentRequestEvent.openWindow()
gogerald1 2017/06/02 13:21:40 Done.
+ void OnOpenWindowForPaymentHandler(int request_id, GURL url);
+ void OnOpenWindow(int request_id,
please use gerrit instead 2017/06/02 03:43:17 Make this private, please.
falken 2017/06/02 07:58:19 +1
gogerald1 2017/06/02 13:21:40 These interfaces are already in private scope,
gogerald1 2017/06/02 13:21:40 Done.
+ GURL url,
+ WindowOpenDisposition disposition);
void OnOpenWindowFinished(int request_id,
ServiceWorkerStatusCode status,
const ServiceWorkerClientInfo& client_info);

Powered by Google App Engine
This is Rietveld 408576698