third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h - Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)

Patch Set: correct file changes Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp ('K') | « third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

index dbf6ed60ddf062dde123e9bd4961de008e1f7165..49733b4085c4607e35275e51852437b592d9bf8d 100644

--- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

+++ b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

@@ -272,7 +272,8 @@ class WebServiceWorkerContextClient {

// should delete the callbacks after calling either onSuccess or onError.

// WebServiceWorkerClientInfo and WebServiceWorkerError ownerships are

// passed to the WebServiceWorkerClientsCallbacks implementation.

- virtual void OpenWindow(const WebURL&,

+ virtual void OpenWindow(const WebURL& redirect_url,

+ const WebURL& url_to_open,

std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0;

// A suggestion to cache this metadata in association with this URL.

« third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp ('K') | « third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp ('k') | no next file » | no next file with comments »