[Payments] Implement openWindow for service worker based payment handler

content/renderer/service_worker/service_worker_context_client.h

Index: content/renderer/service_worker/service_worker_context_client.h
diff --git a/content/renderer/service_worker/service_worker_context_client.h b/content/renderer/service_worker/service_worker_context_client.h
index d0856e9c780817cee22bb5e6955e606091855cfe..42c4de78af6126fe6f7246afb25da1088a27d16d 100644
--- a/content/renderer/service_worker/service_worker_context_client.h
+++ b/content/renderer/service_worker/service_worker_context_client.h
@@ -104,6 +104,7 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,
       std::unique_ptr<blink::WebServiceWorkerClientsCallbacks>) override;
   void OpenWindow(
       const blink::WebURL&,
+      const blink::WebURL&,

[please use gerrit instead, 2017/05/25 14:53:27]

Please provide the names for these parameters. The names are usually omitted
only when it's clear what the parameters are. Here, however, it's not
immediately clear which URL should be opened and which URL is the "redirect"
url.

[gogerald1, 2017/05/25 16:53:32]

Done. Add redirect_url name. check-webkit-style reports "The parameter name
"callbacks"/"url" adds no information, so it should be removed".

[please use gerrit instead, 2017/05/25 17:56:12]

You can remove "callbacks" parameter name and rename "url" parameter into
"url_to_open".

[gogerald1, 2017/05/29 22:13:16]

Done.

       std::unique_ptr<blink::WebServiceWorkerClientCallbacks>) override;
   void SetCachedMetadata(const blink::WebURL&,
                          const char* data,