[Payments] Implement openWindow for service worker based payment handler

chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.tabmodel.document;
 
 import android.app.Activity;
 import android.content.ComponentName;
 import android.content.Intent;
 import android.net.Uri;
 import android.os.Bundle;
 import android.provider.Browser;
+import android.support.customtabs.CustomTabsIntent;
 
 import org.chromium.base.ApiCompatibilityUtils;
+import org.chromium.base.ApplicationStatus;
 import org.chromium.base.ContextUtils;
+import org.chromium.chrome.R;
+import org.chromium.chrome.browser.ChromeActivity;
 import org.chromium.chrome.browser.IntentHandler;
 import org.chromium.chrome.browser.ServiceTabLauncher;
 import org.chromium.chrome.browser.TabState;
 import org.chromium.chrome.browser.document.ChromeLauncherActivity;
 import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.browser.tab.TabIdManager;
 import org.chromium.chrome.browser.tabmodel.AsyncTabParamsManager;
 import org.chromium.chrome.browser.tabmodel.TabCreatorManager.TabCreator;
 import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
+import org.chromium.components.url_formatter.UrlFormatter;
 import org.chromium.content_public.browser.LoadUrlParams;
 import org.chromium.content_public.browser.WebContents;
 import org.chromium.ui.base.PageTransition;
 
 import java.util.Map;
 
 /**
  * Asynchronously creates Tabs by creating/starting up Activities.
  */
 public class TabDelegate extends TabCreator {
@@ skipping 51 matching lines @@
         Class<? extends Activity> targetActivity =
                 MultiWindowUtils.getInstance().getOpenInOtherWindowActivity(activity);
         if (targetActivity == null) return;
 
         MultiWindowUtils.setOpenInOtherWindowIntentExtras(intent, activity, targetActivity);
         IntentHandler.addTrustedIntentExtras(intent);
         MultiWindowUtils.onMultiInstanceModeStarted();
         activity.startActivity(intent);
     }
 
+    /**
+     * Creates a popup custom tab to open the url. The new tab is displayed over the tab showing
+     * redirectUrl.
+     *
+     * @param requestId   The tab launch request ID from the {@link ServiceTabLauncher}.
+     * @param redirectUrl The url of the background tab showing.
+     * @param url         The url to open in the new tab.
+     */
+    public boolean createPopupCustomTab(int requestId, String redirectUrl, String url) {

[please use gerrit instead, 2017/06/01 17:50:37]

Let's be clear when this method would be called: in response to
PaymentRequestEvent.openWindow() call in the payment handler API. Let's put that
in the comment and rename the method to mention "payment" explicitly. Example
method name: "openWindowForPaymentHandler()".

[gogerald1, 2017/06/02 03:33:11]

Acknowledged.

+        // The activity that contains the background tab must be active, otherwise do not open the
+        // new tab.
+        Activity lastTrackedActivity = ApplicationStatus.getLastTrackedFocusedActivity();
+        if (!(lastTrackedActivity instanceof ChromeActivity)) return false;
+        WebContents webcontents =
+                ((ChromeActivity) lastTrackedActivity).getActivityTab().getWebContents();
+        if (webcontents == null) return false;
+
+        // Do not open new tab if the foreground web page is not showing redirect_url.
+        // TODO(gogerald): Match url instead of origin after passed in redirect_url is changed in
+        // PaymentRequestEvent::openWindow.
+        String redirectOrigin = UrlFormatter.formatUrlForSecurityDisplay(redirectUrl, true);
+        if (!redirectOrigin.equals(UrlFormatter.formatUrlForSecurityDisplay(

[please use gerrit instead, 2017/06/01 17:50:37]

I don't think this check is useful, because the user might have two tabs open
with the same URL, both of which would pass this check anyway. Since this is the
only place where "redirectUrl" is being used, I suggest that we do not pass the
"redirectUrl" from the renderer to the browser.

[gogerald1, 2017/06/02 03:33:11]

Done.

+                    webcontents.getLastCommittedUrl(), true))) {
+            return false;
+        }
+
+        CustomTabsIntent.Builder builder = new CustomTabsIntent.Builder();
+        builder.setShowTitle(true);
+        builder.setStartAnimations(lastTrackedActivity, R.anim.slide_in_up, 0);
+        builder.setExitAnimations(lastTrackedActivity, 0, R.anim.slide_out_down);
+        CustomTabsIntent customTabsIntent = builder.build();
+        customTabsIntent.intent.setPackage(ContextUtils.getApplicationContext().getPackageName());
+        customTabsIntent.intent.putExtra(ServiceTabLauncher.LAUNCH_REQUEST_ID_EXTRA, requestId);
+        customTabsIntent.intent.putExtra(IntentHandler.EXTRA_OPEN_NEW_INCOGNITO_TAB, mIsIncognito);
+        customTabsIntent.intent.putExtra(Browser.EXTRA_APPLICATION_ID,
+                ContextUtils.getApplicationContext().getPackageName());
+
+        customTabsIntent.launchUrl(lastTrackedActivity, Uri.parse(url));
+
+        return true;
+    }
+
     @Override
     public Tab launchUrl(String url, TabLaunchType type) {
         return createNewTab(new LoadUrlParams(url), type, null);
     }
 
     @Override
     public Tab createNewTab(LoadUrlParams loadUrlParams, TabLaunchType type, Tab parent) {
         AsyncTabCreationParams asyncParams = new AsyncTabCreationParams(loadUrlParams);
         createNewTab(asyncParams, type, parent == null ? Tab.INVALID_TAB_ID : parent.getId());
         return null;
@@ skipping 71 matching lines @@
      * Passes the supplied web app launch intent to the IntentHandler.
      * @param intent Web app launch intent.
      */
     public void createNewStandaloneFrame(Intent intent) {
         assert intent != null;
         intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK
                 | ApiCompatibilityUtils.getActivityNewDocumentFlag());
         IntentHandler.startActivityForTrustedIntent(intent);
     }
 }