[Payments] Implement openWindow for service worker based payment handler

chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.payments;
 
 import android.app.Activity;
 import android.content.Context;
 import android.content.Intent;
 import android.graphics.Bitmap;
@@ skipping 240 matching lines @@
         @Override
         public void didSelectTab(Tab tab, TabSelectionType type, int lastId) {
             if (tab == null || tab.getId() != lastId) onDismiss();
         }
     };
 
     private final Handler mHandler = new Handler();
     private final RenderFrameHost mRenderFrameHost;
     private final WebContents mWebContents;
     private final String mTopLevelOrigin;
+    private final String mTopLevelOriginForDisplay;
     private final String mPaymentRequestOrigin;
     private final String mMerchantName;
     @Nullable
     private final byte[][] mCertificateChain;
     private final AddressEditor mAddressEditor;
     private final CardEditor mCardEditor;
     private final JourneyLogger mJourneyLogger;
     private final boolean mIsIncognito;
 
     private PaymentRequestClient mClient;
@@ skipping 87 matching lines @@
      * Builds the PaymentRequest service implementation.
      *
      * @param renderFrameHost The host of the frame that has invoked the PaymentRequest API.
      */
     public PaymentRequestImpl(RenderFrameHost renderFrameHost) {
         assert renderFrameHost != null;
 
         mRenderFrameHost = renderFrameHost;
         mWebContents = WebContentsStatics.fromRenderFrameHost(renderFrameHost);
 
-        mPaymentRequestOrigin = UrlFormatter.formatUrlForSecurityDisplay(
-                mRenderFrameHost.getLastCommittedURL(), true);
-        mTopLevelOrigin =
-                UrlFormatter.formatUrlForSecurityDisplay(mWebContents.getLastCommittedUrl(), true);
+        mPaymentRequestOrigin = mRenderFrameHost.getLastCommittedURL();
+        mTopLevelOrigin = mWebContents.getLastCommittedUrl();

[please use gerrit instead, 2017/05/25 14:53:26]

That's a top level URL, because it contains the full path. Origins do not have a
path. Therefore, this variable should be called mTopLevelUrl.

[gogerald1, 2017/05/25 16:53:32]

Done.

+        mTopLevelOriginForDisplay = UrlFormatter.formatUrlForSecurityDisplay(mTopLevelOrigin, true);

[please use gerrit instead, 2017/05/25 14:53:26]

This should remain mTopLevelOrigin.

[gogerald1, 2017/05/25 16:53:32]

Done.

 
         mMerchantName = mWebContents.getTitle();
 
         mCertificateChain = CertificateChainHelper.getCertificateChain(mWebContents);
 
         mApps = new ArrayList<>();
 
         mAddressEditor = new AddressEditor();
         mCardEditor = new CardEditor(mWebContents, mAddressEditor, sObserverForTest);
 
@@ skipping 128 matching lines @@
             mContactEditor =
                     new ContactEditor(mRequestPayerName, mRequestPayerPhone, mRequestPayerEmail);
             mContactSection = new ContactDetailsSection(
                     activity, Collections.unmodifiableList(profiles), mContactEditor);
         }
 
         setIsAnyPaymentRequestShowing(true);
         mUI = new PaymentRequestUI(activity, this, mRequestShipping,
                 mRequestPayerName || mRequestPayerPhone || mRequestPayerEmail,
                 mMerchantSupportsAutofillPaymentInstruments,
-                !PaymentPreferencesUtil.isPaymentCompleteOnce(), mMerchantName, mTopLevelOrigin,
+                !PaymentPreferencesUtil.isPaymentCompleteOnce(), mMerchantName,
+                mTopLevelOriginForDisplay,
                 SecurityStateModel.getSecurityLevelForWebContents(mWebContents),
                 new ShippingStrings(mShippingType));
 
         final FaviconHelper faviconHelper = new FaviconHelper();
         faviconHelper.getLocalFaviconImageForURL(Profile.getLastUsedProfile(),
                 mWebContents.getLastCommittedUrl(),
                 activity.getResources().getDimensionPixelSize(R.dimen.payments_favicon_size),
                 new FaviconHelper.FaviconImageCallback() {
                     @Override
                     public void onFaviconAvailable(Bitmap bitmap, String iconUrl) {
@@ skipping 1334 matching lines @@
 
     /**
      * The frecency score is calculated according to use count and last use date. The formula is
      * the same as the one used in GetFrecencyScore in autofill_data_model.cc.
      */
     private static final double getFrecencyScore(int count, long date) {
         long currentTime = System.currentTimeMillis();
         return -Math.log((currentTime - date) / (24 * 60 * 60 * 1000) + 2) / Math.log(count + 2);
     }
 }