Issue 2893813002: Revert "Flatten futures when inferring the type of an async function expression."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2893813002: Revert "Flatten futures when inferring the type of an async function expression." (Closed)

Created:
3 years, 7 months ago by Paul Berry

Modified:
3 years, 7 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Flatten futures when inferring the type of an async function expression." This reverts commit a0d98fe474b622e28240cff03012057c5bfb6ec8. This should address failures in the buildbot "vm-kernel-linux-release-x64-be". TBR=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/8c04f1a7f95bb001dfbc98c86a39ebb3b83a536f

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -69 lines)			Patch
M	pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	pkg/front_end/test/fasta/strong.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/front_end/testcases/inference/async_closure_return_type_flatten.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	pkg/front_end/testcases/inference/async_closure_return_type_flatten.dart.strong.expect	View	1 chunk	+0 lines, -36 lines	0 comments	Download

Total messages: 2 (1 generated)

Paul Berry

3 years, 7 months ago (2017-05-18 03:24:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8c04f1a7f95bb001dfbc98c86a39ebb3b83a536f (presubmit successful).