Capture the request time for performance data and support forced shutdown

Capture the request time for performance data and support forced shutdown

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/a8dc04154314801da63de006dfdd64a85d83fb31

[Brian Wilkerson, 2017-05-18 21:21:00]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-05-18 21:36:16]

LGTM

https://codereview.chromium.org/2893803004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/plugin/plugin_manager.dart (right):

https://codereview.chromium.org/2893803004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/plugin_manager.dart:839: final int
requestTime;
Or you could use new Stopwatch()..start() instead.

[Brian Wilkerson, 2017-05-18 21:51:39]

https://codereview.chromium.org/2893803004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/plugin/plugin_manager.dart (right):

https://codereview.chromium.org/2893803004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/plugin_manager.dart:839: final int
requestTime;
> Or you could use new Stopwatch()..start() instead.

I hadn't considered that, but now that I think about it, I have concerns
(possibly unwarranted) about the memory management issues of creating more
objects and holding on to them just until the plugin has responded. If they
never graduate from new space it shouldn't be a problem, but...

Unless there's a compelling reason to change it, I think I'll leave it as is.

[scheglov, 2017-05-18 21:55:55]

https://codereview.chromium.org/2893803004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/plugin/plugin_manager.dart (right):

https://codereview.chromium.org/2893803004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/plugin_manager.dart:839: final int
requestTime;
On 2017/05/18 21:51:39, Brian Wilkerson wrote:
> > Or you could use new Stopwatch()..start() instead.
> 
> I hadn't considered that, but now that I think about it, I have concerns
> (possibly unwarranted) about the memory management issues of creating more
> objects and holding on to them just until the plugin has responded. If they
> never graduate from new space it shouldn't be a problem, but...
> 
> Unless there's a compelling reason to change it, I think I'll leave it as is.

It's fine with my any way, just thought about other way, which could be simpler.

[Brian Wilkerson, 2017-05-19 15:49:52]

Description was changed from

==========
Capture the request time for performance data and support forced shutdown
==========

to

==========
Capture the request time for performance data and support forced shutdown

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a8dc04154314801da63de006dfdd64a85d83fb31
==========

[Brian Wilkerson, 2017-05-19 15:49:55]

Committed patchset #1 (id:1) manually as
a8dc04154314801da63de006dfdd64a85d83fb31 (presubmit successful).