Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2893803003: Add metadata annotations to library definitions. (Closed)

Created:
3 years, 7 months ago by asgerf
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add metadata annotations to library definitions. BUG= R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/1ea216e6de26e05257901e8df4d9757e3a9c0e85

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M pkg/kernel/binary.md View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/kernel/lib/ast.dart View 4 chunks +9 lines, -1 line 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/kernel/lib/binary/ast_to_binary.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/kernel/lib/text/ast_to_text.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/kernel.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/kernel.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/kernel_binary.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
3 years, 7 months ago (2017-05-18 13:39:49 UTC) #2
ahe
lgtm
3 years, 7 months ago (2017-05-18 13:45:23 UTC) #3
asgerf
3 years, 7 months ago (2017-05-19 09:35:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1ea216e6de26e05257901e8df4d9757e3a9c0e85 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698