Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2893753002: [ObjC ARC] Converts ios/chrome/browser/snapshots:snapshots_internal to ARC. (Closed)

Created:
3 years, 7 months ago by liaoyuke
Modified:
3 years, 6 months ago
Reviewers:
jif
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/snapshots:snapshots_internal to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2893753002 Cr-Commit-Position: refs/heads/master@{#475953} Committed: https://chromium.googlesource.com/chromium/src/+/49bc360545589a1e22186b537d2943b30b91b267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M ios/chrome/browser/snapshots/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/snapshots/web_controller_snapshot_helper.mm View 6 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
liaoyuke
Hi jif@, PTAL. Thank you very much!
3 years, 6 months ago (2017-05-30 17:40:07 UTC) #6
jif
lgtm
3 years, 6 months ago (2017-05-31 08:45:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893753002/1
3 years, 6 months ago (2017-05-31 15:51:58 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 17:19:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/49bc360545589a1e22186b537d29...

Powered by Google App Engine
This is Rietveld 408576698