Support for YUV 4:4:4 subsampling.

Support for YUV 4:4:4 subsampling.

Plumb a new VideoFrame format (YV24) through the stack and add a conversion using libyuv to the software path.

BUG=104711
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274434

[sandersd (OOO until July 31), 2014-05-22 23:20:43]

Still needs some minor updates to the tests, otherwise I believe this is ready.

[scherkus (not reviewing), 2014-05-22 23:45:11]

cool!

https://codereview.chromium.org/289373011/diff/20001/media/base/video_frame.cc
File media/base/video_frame.cc (right):

https://codereview.chromium.org/289373011/diff/20001/media/base/video_frame.c...
media/base/video_frame.cc:553: default:
can you replace the default cases w/ the other format enums, similar to
PlaneSize()?

https://codereview.chromium.org/289373011/diff/20001/media/base/video_frame.c...
media/base/video_frame.cc:714: default:
ditto -- and remove the comment about intentionally leaving out formats

https://codereview.chromium.org/289373011/diff/20001/media/base/video_frame.c...
media/base/video_frame.cc:773: default:
ditto

https://codereview.chromium.org/289373011/diff/20001/media/base/video_frame.h
File media/base/video_frame.h (right):

https://codereview.chromium.org/289373011/diff/20001/media/base/video_frame.h...
media/base/video_frame.h:60: I444 = 9,  // 24bpp YUV planer, no subsampling.
s/planer/planar/

it seems like we have I420 to represent U-V ordered planar data, which means
this should be YV24 to be consistent with our other V-U enums

https://codereview.chromium.org/289373011/diff/20001/media/ffmpeg/ffmpeg_comm...
File media/ffmpeg/ffmpeg_common.cc (right):

https://codereview.chromium.org/289373011/diff/20001/media/ffmpeg/ffmpeg_comm...
media/ffmpeg/ffmpeg_common.cc:547: return PIX_FMT_YUV422P;
shouldn't this be PIX_FMT_YUV444P?

https://codereview.chromium.org/289373011/diff/20001/media/filters/skcanvas_v...
File media/filters/skcanvas_video_renderer.cc (right):

https://codereview.chromium.org/289373011/diff/20001/media/filters/skcanvas_v...
media/filters/skcanvas_video_renderer.cc:9: #include "media/base/yuv_convert.h"
is this still used?

https://codereview.chromium.org/289373011/diff/20001/media/filters/skcanvas_v...
media/filters/skcanvas_video_renderer.cc:211: // Do a slower paint using
|last_frame_|.
remove references to paints being slow(er)

[rileya (GONE FROM CHROMIUM), 2014-05-22 23:58:35]

driveby: sweet! didn't realize someone finally added libyuv (a week ago haha),
looks like the media/simd/ YUV conversion code is almost dead (minus JPEG and
YUVA). A good followup might be to kill that code off for good.

[scherkus (not reviewing), 2014-05-22 23:59:40]

https://codereview.chromium.org/289373011/diff/20001/media/filters/skcanvas_v...
File media/filters/skcanvas_video_renderer.cc (left):

https://codereview.chromium.org/289373011/diff/20001/media/filters/skcanvas_v...
media/filters/skcanvas_video_renderer.cc:59: static bool CanFastPaint(SkCanvas*
canvas, uint8 alpha,
fischman and I chatted that perhaps we should leave this in and have a
[D]CHECK() until we're positive fast paint is dead

[sandersd (OOO until July 31), 2014-05-23 00:45:21]

https://codereview.chromium.org/289373011/diff/20001/media/base/video_frame.cc
File media/base/video_frame.cc (right):

https://codereview.chromium.org/289373011/diff/20001/media/base/video_frame.c...
media/base/video_frame.cc:553: default:
On 2014/05/22 23:45:11, scherkus wrote:
> can you replace the default cases w/ the other format enums, similar to
> PlaneSize()?

Done.

https://codereview.chromium.org/289373011/diff/20001/media/base/video_frame.c...
media/base/video_frame.cc:714: default:
On 2014/05/22 23:45:11, scherkus wrote:
> ditto -- and remove the comment about intentionally leaving out formats

Done.

https://codereview.chromium.org/289373011/diff/20001/media/base/video_frame.c...
media/base/video_frame.cc:773: default:
On 2014/05/22 23:45:11, scherkus wrote:
> ditto

Done.

https://codereview.chromium.org/289373011/diff/20001/media/base/video_frame.h
File media/base/video_frame.h (right):

https://codereview.chromium.org/289373011/diff/20001/media/base/video_frame.h...
media/base/video_frame.h:60: I444 = 9,  // 24bpp YUV planer, no subsampling.
On 2014/05/22 23:45:11, scherkus wrote:
> s/planer/planar/
> 
> it seems like we have I420 to represent U-V ordered planar data, which means
> this should be YV24 to be consistent with our other V-U enums

Works for me. (Although I did't find a code path where I420 and YV12 are handled
differently.)

https://codereview.chromium.org/289373011/diff/20001/media/ffmpeg/ffmpeg_comm...
File media/ffmpeg/ffmpeg_common.cc (right):

https://codereview.chromium.org/289373011/diff/20001/media/ffmpeg/ffmpeg_comm...
media/ffmpeg/ffmpeg_common.cc:547: return PIX_FMT_YUV422P;
On 2014/05/22 23:45:11, scherkus wrote:
> shouldn't this be PIX_FMT_YUV444P?

Done.

https://codereview.chromium.org/289373011/diff/20001/media/filters/skcanvas_v...
File media/filters/skcanvas_video_renderer.cc (left):

https://codereview.chromium.org/289373011/diff/20001/media/filters/skcanvas_v...
media/filters/skcanvas_video_renderer.cc:59: static bool CanFastPaint(SkCanvas*
canvas, uint8 alpha,
On 2014/05/22 23:59:40, scherkus wrote:
> fischman and I chatted that perhaps we should leave this in and have a
> [D]CHECK() until we're positive fast paint is dead

:-(

I've restored this and added a check to skip it for I444. When will we be
positive that it's dead?

https://codereview.chromium.org/289373011/diff/20001/media/filters/skcanvas_v...
File media/filters/skcanvas_video_renderer.cc (right):

https://codereview.chromium.org/289373011/diff/20001/media/filters/skcanvas_v...
media/filters/skcanvas_video_renderer.cc:9: #include "media/base/yuv_convert.h"
On 2014/05/22 23:45:11, scherkus wrote:
> is this still used?

Yes, YV12J and YV12A still use it.

https://codereview.chromium.org/289373011/diff/20001/media/filters/skcanvas_v...
media/filters/skcanvas_video_renderer.cc:211: // Do a slower paint using
|last_frame_|.
On 2014/05/22 23:45:11, scherkus wrote:
> remove references to paints being slow(er)

Done.

[chromium-reviews, 2014-05-23 01:03:53]

drive-by

On Thu, May 22, 2014 at 4:58 PM, <rileya@chromium.org> wrote:

> A good followup might be to kill that code off for good.


FYI http://crbug.com/369375

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scherkus (not reviewing), 2014-05-23 02:31:31]

lgtm

[sandersd (OOO until July 31), 2014-05-23 21:52:37]

piman: please review cc/*.

[piman, 2014-05-23 22:04:58]

lgtm

[sandersd (OOO until July 31), 2014-05-27 19:09:54]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2014-05-27 19:11:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sandersd@chromium.org/289373011/40001

[sandersd (OOO until July 31), 2014-05-27 19:16:51]

The CQ bit was unchecked by sandersd@chromium.org

[sandersd (OOO until July 31), 2014-05-27 19:19:11]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2014-05-27 19:20:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sandersd@chromium.org/289373011/60001

[commit-bot: I haz the power, 2014-05-27 23:39:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-27 23:41:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 23:42:00]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[sandersd (OOO until July 31), 2014-05-28 20:10:45]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2014-05-28 20:12:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sandersd@chromium.org/289373011/60001

[commit-bot: I haz the power, 2014-05-29 00:31:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-29 00:33:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-29 00:33:56]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Ken Russell (switch to Gerrit), 2014-05-29 00:43:39]

On 2014/05/29 00:33:56, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_gpu_triggered_tests on tryserver.chromium.gpu
>
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
>   mac_gpu_triggered_tests on tryserver.chromium.gpu
>
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
>   win_gpu_triggered_tests on tryserver.chromium.gpu
>
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

FYI, the test failures above look real. Please investigate them and contact me
if you have any difficulty reproducing them locally.

[sandersd (OOO until July 31), 2014-05-29 21:47:14]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2014-05-29 21:50:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sandersd@chromium.org/289373011/110008

[commit-bot: I haz the power, 2014-05-30 01:37:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)

[commit-bot: I haz the power, 2014-05-30 01:44:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-30 01:44:27]

Try jobs failed on following builders:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)

[sandersd (OOO until July 31), 2014-05-30 17:53:51]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2014-05-30 17:57:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sandersd@chromium.org/289373011/130001

[sandersd (OOO until July 31), 2014-05-30 18:23:24]

The CQ bit was unchecked by sandersd@chromium.org

[sandersd (OOO until July 31), 2014-06-02 23:23:51]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2014-06-02 23:24:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sandersd@chromium.org/289373011/170001

[commit-bot: I haz the power, 2014-06-03 03:08:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-06-03 08:46:03]

Change committed as 274434