Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/base/prefs/pref_member.h

Issue 289373006: Revert 271416 "Store a stacktrace of PrefService destruction in ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/base/prefs/pref_change_registrar.cc ('k') | trunk/src/base/prefs/pref_member.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/base/prefs/pref_member.h
===================================================================
--- trunk/src/base/prefs/pref_member.h (revision 271621)
+++ trunk/src/base/prefs/pref_member.h (working copy)
@@ -117,9 +117,6 @@
// PrefObserver
virtual void OnPreferenceChanged(PrefService* service,
const std::string& pref_name) OVERRIDE;
- // TODO(battre): Remove function (debugging tool for crbug.com/373435).
- virtual void SetPrefServiceDestructionTrace(
- const std::string& stack_trace) OVERRIDE;
void VerifyValuePrefName() const {
DCHECK(!pref_name_.empty());
@@ -147,8 +144,6 @@
std::string pref_name_;
NamedChangeCallback observer_;
PrefService* prefs_;
- // TODO(battre): Remove attribute (debugging tool for crbug.com/373435).
- std::string pref_service_destruction_;
protected:
bool setting_value_;
« no previous file with comments | « trunk/src/base/prefs/pref_change_registrar.cc ('k') | trunk/src/base/prefs/pref_member.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698