Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: trunk/src/base/prefs/pref_change_registrar.h

Issue 289373006: Revert 271416 "Store a stacktrace of PrefService destruction in ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/base/prefs/pref_change_registrar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/base/prefs/pref_change_registrar.h
===================================================================
--- trunk/src/base/prefs/pref_change_registrar.h (revision 271621)
+++ trunk/src/base/prefs/pref_change_registrar.h (working copy)
@@ -66,9 +66,6 @@
// PrefObserver:
virtual void OnPreferenceChanged(PrefService* service,
const std::string& pref_name) OVERRIDE;
- // TODO(battre): Delete function. See crbug.com/373435.
- virtual void SetPrefServiceDestructionTrace(
- const std::string& stack_trace) OVERRIDE;
static void InvokeUnnamedCallback(const base::Closure& callback,
const std::string& pref_name);
@@ -77,8 +74,6 @@
ObserverMap observers_;
PrefService* service_;
- // TODO(battre): Remove attribute (debugging tool for crbug.com/373435).
- std::string pref_service_destruction_;
DISALLOW_COPY_AND_ASSIGN(PrefChangeRegistrar);
};
« no previous file with comments | « no previous file | trunk/src/base/prefs/pref_change_registrar.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698