Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 289373005: Parser: delay throwing errors. (Closed)

Created:
6 years, 7 months ago by marja
Modified:
6 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Parser: delay throwing errors. This makes Parser a bit more independent of Isolate during the recursive descent phase. That is necessary for making it possible to run Parser on a non-main thread in the future. Proof of concept CL for the the "Parser independent of Isolate" work is here: https://codereview.chromium.org/231073002/ BUG= R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -30 lines) Patch
M src/parser.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/parser.cc View 6 chunks +49 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
rossberg, ptal This is an independent chunk split out of the "delay string internalization" WIP ...
6 years, 7 months ago (2014-05-20 09:04:59 UTC) #1
rossberg
lgtm
6 years, 7 months ago (2014-05-20 12:19:00 UTC) #2
marja
6 years, 7 months ago (2014-05-20 12:22:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21385 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698