Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 289373002: Fix browser test to work with dynamic CLD (Closed)

Created:
6 years, 7 months ago by Andrew Hayden (chromium.org)
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@cld_browsertest
Visibility:
Public.

Description

Fix browser test to work with dynamic CLD BUG=367239 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271819

Patch Set 1 #

Patch Set 2 : Add call to Init() to workaround gtest macro issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/ui/browser_browsertest.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Andrew Hayden (chromium.org)
Dear owner: NB: This change depends upon https://codereview.chromium.org/285293004/. We are making it possible for the ...
6 years, 7 months ago (2014-05-19 12:55:04 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 7 months ago (2014-05-20 19:25:57 UTC) #2
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 7 months ago (2014-05-20 19:45:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/289373002/20001
6 years, 7 months ago (2014-05-20 19:45:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 21:30:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 22:46:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/29138)
6 years, 7 months ago (2014-05-20 22:46:20 UTC) #7
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 7 months ago (2014-05-20 23:45:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/289373002/20001
6 years, 7 months ago (2014-05-20 23:47:06 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 02:27:11 UTC) #10
Message was sent while issue was closed.
Change committed as 271819

Powered by Google App Engine
This is Rietveld 408576698