chrome/test/data/extensions/api_test/lazy_events/new_event_in_new_version/v1/manifest.json - Issue 2893693002: Remove NOTIFICATION_EXTENSION_ENABLED.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/lazy_events/new_event_in_new_version/v1/manifest.json

Issue 2893693002: Remove NOTIFICATION_EXTENSION_ENABLED. (Closed)

Patch Set: connect devtools Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {

	2 "version": "1",

	3 "name": "Lazy events test: tabs.onCreated added in version 2",

	4 "background": {"scripts": ["background.js"]},

	5 "permissions": ["tabs"],
	Devlin 2017/05/23 21:30:36 You actually don't need the tabs permission to lis You actually don't need the tabs permission to listen to tabs.onCreated. lazyboy 2017/05/23 23:19:08 Done. Show quoted text On 2017/05/23 21:30:36, Devlin (catching up) wrote: > You actually don't need the tabs permission to listen to tabs.onCreated. Done.
	6 "update_url": "http://localhost/autoupdate/updates.xml"
	Devlin 2017/05/23 21:30:36 do we need this? do we need this? lazyboy 2017/05/23 23:19:08 Nope, copied from somewhere that had it. Removed. Show quoted text On 2017/05/23 21:30:36, Devlin (catching up) wrote: > do we need this? Nope, copied from somewhere that had it. Removed.
	7 }

OLD	NEW