js_runtime: loadDeferredLibrary: don't call initializer of repeated empty parts

js_runtime: loadDeferredLibrary: don't call initializer of repeated empty parts

Pre-filtering hunks to initialized ended up calling some initializations multiple times. This happened for empty parts, so was harmless after https://github.com/dart-lang/sdk/commit/4af03b1a658675c8490e8c4c3721e6a2991c17e9

Simplify logic to reduce use of corelib functions. There is no real need to be creating closures and calling all of List.generate, where, and map.

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/7983454299a3e2ee89fd5e3ae20f4a389d39a4b1

[sra1, 2017-05-18 20:43:37]

Description was changed from

==========
js_runtime: loadDeferredLibrary: don't call initializer of repeated empty parts

Pre-filtering hunks to initialized ended up calling some initializations
multiple times. This happened for empty parts, so was harmless.

Simplify logic to reduce use of corelib functions. There is no real need to be
creating closures and calling all of List.generate, where, and map.

BUG=
==========

to

==========
js_runtime: loadDeferredLibrary: don't call initializer of repeated empty parts

Pre-filtering hunks to initialized ended up calling some initializations
multiple times. This happened for empty parts, so was harmless after
https://github.com/dart-lang/sdk/commit/4af03b1a658675c8490e8c4c3721e6a2991c17e9

Simplify logic to reduce use of corelib functions. There is no real need to be
creating closures and calling all of List.generate, where, and map.

BUG=
==========

[sra1, 2017-05-18 20:43:37]

sra@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-05-18 20:54:37]

lgtm

https://codereview.chromium.org/2893653005/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/js_helper.dart (right):

https://codereview.chromium.org/2893653005/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/js_helper.dart:3661: List<String> unloadedUris
= <String>[];
nit: rename to urisToLoad (unloadedUris almost sounds like you intend to undo
the loading :))

[sra1, 2017-05-18 21:16:16]

https://codereview.chromium.org/2893653005/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/js_helper.dart (right):

https://codereview.chromium.org/2893653005/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/js_helper.dart:3661: List<String> unloadedUris
= <String>[];
On 2017/05/18 20:54:37, Siggi Cherem (dart-lang) wrote:
> nit: rename to urisToLoad (unloadedUris almost sounds like you intend to undo
> the loading :))

Done.

[sra1, 2017-05-18 21:16:53]

Description was changed from

==========
js_runtime: loadDeferredLibrary: don't call initializer of repeated empty parts

Pre-filtering hunks to initialized ended up calling some initializations
multiple times. This happened for empty parts, so was harmless after
https://github.com/dart-lang/sdk/commit/4af03b1a658675c8490e8c4c3721e6a2991c17e9

Simplify logic to reduce use of corelib functions. There is no real need to be
creating closures and calling all of List.generate, where, and map.

BUG=
==========

to

==========
js_runtime: loadDeferredLibrary: don't call initializer of repeated empty parts

Pre-filtering hunks to initialized ended up calling some initializations
multiple times. This happened for empty parts, so was harmless after
https://github.com/dart-lang/sdk/commit/4af03b1a658675c8490e8c4c3721e6a2991c17e9

Simplify logic to reduce use of corelib functions. There is no real need to be
creating closures and calling all of List.generate, where, and map.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7983454299a3e2ee89fd5e3ae20f4a389d39a4b1
==========

[sra1, 2017-05-18 21:16:53]

Committed patchset #2 (id:20001) manually as
7983454299a3e2ee89fd5e3ae20f4a389d39a4b1 (presubmit successful).