[Password Manager] Make filling robust against changing url by JavaScript

components/autofill/content/renderer/password_form_conversion_utils.cc

Index: components/autofill/content/renderer/password_form_conversion_utils.cc
diff --git a/components/autofill/content/renderer/password_form_conversion_utils.cc b/components/autofill/content/renderer/password_form_conversion_utils.cc
index 5d56dc545bee414ea11b71317057401f2708b16b..825f44621b91938fe3c784629d38498141d2b701 100644
--- a/components/autofill/content/renderer/password_form_conversion_utils.cc
+++ b/components/autofill/content/renderer/password_form_conversion_utils.cc
@@ -593,10 +593,7 @@ bool GetPasswordForm(
 
   password_form->origin =
       form_util::GetCanonicalOriginForDocument(form.document);
-  GURL::Replacements rep;
-  rep.SetPathStr("");
-  password_form->signon_realm =
-      password_form->origin.ReplaceComponents(rep).spec();
+  password_form->signon_realm = GetSignOnRealm(password_form->origin);
   password_form->other_possible_usernames.swap(other_possible_usernames);
 
   if (!password.IsNull()) {
@@ -781,4 +778,10 @@ bool IsCreditCardVerificationPasswordField(
          MatchesPattern(field.GetAttribute("name").Utf16(), kCardCvcReCached);
 }
 
+std::string GetSignOnRealm(const GURL& origin) {

[kolos1, 2017/05/18 09:52:53]

There might be confusion with GetSignonRealm from
chrome/browser/ui/login/login_handler.h. This function could not remove path as
I understand. And we use it here
https://cs.chromium.org/chromium/src/chrome/browser/ui/login/login_handler.cc...

[dvadym, 2017/05/18 11:08:52]

GetSignOnRealm is very good name :). I don't think that there will be any
confusions, this function is in autofill namespace an it's used in rederer.
That's exactly why namespaces are needed :)

[kolos1, 2017/05/18 11:11:50]

Acknowledged.

+  GURL::Replacements rep;
+  rep.SetPathStr("");

[kolos1, 2017/05/18 09:52:53]

Shall we also clear Query, Ref, Username, Password as we do for example here:
https://cs.chromium.org/chromium/src/chrome/utility/importer/nss_decryptor.cc...

[dvadym, 2017/05/18 11:08:52]

This is just extracting of logic that we had for calculating of signon_realm. As
far as I understand it removes everything, only scheme:host:port are left.

[kolos1, 2017/05/18 11:11:50]

Acknowledged.

+  return origin.ReplaceComponents(rep).spec();
+}
+
 }  // namespace autofill