runtime/vm/object.cc - Issue 2893553002: More compact string representation on 64 bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 2893553002: More compact string representation on 64 bit. (Closed)

Patch Set: Slava feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index a6ba79ffd30daf4695c7a0ed0c9d35acc87397cd..950c03e5621fbbc7c1f621e80be6c1b189be4a4f 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -21337,7 +21337,9 @@ RawOneByteString* OneByteString::New(intptr_t len, Heap::Space space) {

NoSafepointScope no_safepoint;

RawOneByteString* result = reinterpret_cast<RawOneByteString*>(raw);

result->StoreSmi(&(result->ptr()->length_), Smi::New(len));

+#if !defined(HASH_IN_OBJECT_HEADER)

result->StoreSmi(&(result->ptr()->hash_), Smi::New(0));

+#endif

return result;

}

« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »