Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: runtime/vm/dart.cc

Issue 2893553002: More compact string representation on 64 bit. (Closed)
Patch Set: Slava feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/clustered_snapshot.cc ('k') | runtime/vm/globals.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/become.h" 7 #include "vm/become.h"
8 #include "vm/clustered_snapshot.h" 8 #include "vm/clustered_snapshot.h"
9 #include "vm/code_observers.h" 9 #include "vm/code_observers.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 CHECK_OFFSET(SingleTargetCache::upper_limit_offset(), 14); 106 CHECK_OFFSET(SingleTargetCache::upper_limit_offset(), 14);
107 CHECK_OFFSET(Isolate::object_store_offset(), 28); 107 CHECK_OFFSET(Isolate::object_store_offset(), 28);
108 NOT_IN_PRODUCT(CHECK_OFFSET(sizeof(ClassHeapStats), 120)); 108 NOT_IN_PRODUCT(CHECK_OFFSET(sizeof(ClassHeapStats), 120));
109 #endif 109 #endif
110 #if defined(TARGET_ARCH_ARM64) 110 #if defined(TARGET_ARCH_ARM64)
111 // These offsets are embedded in precompiled instructions. We need simarm64 111 // These offsets are embedded in precompiled instructions. We need simarm64
112 // (compiler) and arm64 (runtime) to agree. 112 // (compiler) and arm64 (runtime) to agree.
113 CHECK_OFFSET(Heap::TopOffset(Heap::kNew), 8); 113 CHECK_OFFSET(Heap::TopOffset(Heap::kNew), 8);
114 CHECK_OFFSET(Thread::stack_limit_offset(), 8); 114 CHECK_OFFSET(Thread::stack_limit_offset(), 8);
115 CHECK_OFFSET(Thread::object_null_offset(), 80); 115 CHECK_OFFSET(Thread::object_null_offset(), 80);
116 CHECK_OFFSET(SingleTargetCache::upper_limit_offset(), 28); 116 CHECK_OFFSET(SingleTargetCache::upper_limit_offset(), 26);
117 CHECK_OFFSET(Isolate::object_store_offset(), 56); 117 CHECK_OFFSET(Isolate::object_store_offset(), 56);
118 NOT_IN_PRODUCT(CHECK_OFFSET(sizeof(ClassHeapStats), 208)); 118 NOT_IN_PRODUCT(CHECK_OFFSET(sizeof(ClassHeapStats), 208));
119 #endif 119 #endif
120 #undef CHECK_OFFSET 120 #undef CHECK_OFFSET
121 } 121 }
122 122
123 123
124 char* Dart::InitOnce(const uint8_t* vm_isolate_snapshot, 124 char* Dart::InitOnce(const uint8_t* vm_isolate_snapshot,
125 const uint8_t* instructions_snapshot, 125 const uint8_t* instructions_snapshot,
126 Dart_IsolateCreateCallback create, 126 Dart_IsolateCreateCallback create,
(...skipping 639 matching lines...) Expand 10 before | Expand all | Expand 10 after
766 return predefined_handles_->handles_.IsValidScopedHandle(address); 766 return predefined_handles_->handles_.IsValidScopedHandle(address);
767 } 767 }
768 768
769 769
770 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) { 770 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) {
771 ASSERT(predefined_handles_ != NULL); 771 ASSERT(predefined_handles_ != NULL);
772 return predefined_handles_->api_handles_.IsValidHandle(handle); 772 return predefined_handles_->api_handles_.IsValidHandle(handle);
773 } 773 }
774 774
775 } // namespace dart 775 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/clustered_snapshot.cc ('k') | runtime/vm/globals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698