Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6805)

Unified Diff: chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc

Issue 2893523004: Disable WebRtcVideoQualityBrowserTest.TestVideoQualityH264/0 on Win bots. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc
diff --git a/chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc b/chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc
index ff7e2b34ef19808fbbca4f451cd0012368157314..c7f94847d96c8f7740ab82f4d1504dbae89f3a44 100644
--- a/chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc
+++ b/chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc
@@ -357,8 +357,15 @@ IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
#if BUILDFLAG(RTC_USE_H264)
+// TODO(philipel): Remove disable condition when H264 flakyness has been
+// investigated (crbug.com/722746).
+#if defined(OS_WIN)
+ #define MAYBE_TestVideoQualityH264 DISABLED_TestVideoQualityH264
tommi (sloooow) - chröme 2017/05/18 11:45:42 nit: we don't indent #defines.
+#else
+ #define MAYBE_TestVideoQualityH264 MANUAL_TestVideoQualityH264
+#endif
IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
- MANUAL_TestVideoQualityH264) {
+ MAYBE_TestVideoQualityH264) {
base::ThreadRestrictions::ScopedAllowIO allow_io;
// Only run test if run-time feature corresponding to |rtc_use_h264| is on.
if (!base::FeatureList::IsEnabled(content::kWebRtcH264WithOpenH264FFmpeg)) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698