Support DDC debugging tools.

lib/src/dartdevc/dartdevc_environment.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
 import 'package:async/async.dart';
 import 'package:barback/barback.dart';
@@ skipping 17 matching lines @@
 /// barback doesn't provide a mechanism to tell you which files have changed.
 class DartDevcEnvironment {
   final _AssetCache _assetCache;
   final Barback _barback;
   final Map<String, String> _environmentConstants;
   final BarbackMode _mode;
   ModuleReader _moduleReader;
   final PackageGraph _packageGraph;
   ScratchSpace _scratchSpace;
 
+  static final _sdkResources = <String, String>{
+    'dart_sdk.js': 'lib/dev_compiler/amd/dart_sdk.js',
+    'require.js': 'lib/dev_compiler/amd/require.js',
+    'dart_stack_trace_mapper.js':
+        'lib/dev_compiler/web/dart_stack_trace_mapper.js',
+    'ddc_web_compiler.js': 'lib/dev_compiler/web/ddc_web_compiler.js',
+  };
+
   DartDevcEnvironment(
       this._barback, this._mode, this._environmentConstants, this._packageGraph)
       : _assetCache = new _AssetCache(_packageGraph) {
     _moduleReader = new ModuleReader(_readModule);
     _scratchSpace = new ScratchSpace(_getAsset);
   }
 
   /// Deletes the [_scratchSpace] and shuts down the workers.
   Future cleanUp() {
     return Future.wait([
@@ skipping 36 matching lines @@
       }
 
       // Build all required modules for the apps that were discovered.
       var allFutureAssets = <Future<Asset>>[];
       for (var module in modulesToBuild) {
         allFutureAssets
             .addAll(_buildAsset(module.jsId, logError: logError).values);
       }
       // Copy all JS resoureces for each of the app dirs that were discovered.
       for (var dir in appDirs) {
-        allFutureAssets
-          ..add(_buildJsResource(new AssetId(_packageGraph.entrypoint.root.name,
-              p.url.join(dir, 'dart_sdk.js'))))
-          ..add(_buildJsResource(new AssetId(_packageGraph.entrypoint.root.name,
-              p.url.join(dir, 'require.js'))));
+        for (var name in _sdkResources.keys) {
+          allFutureAssets.add(_buildJsResource(new AssetId(
+              _packageGraph.entrypoint.root.name, p.url.join(dir, name))));
+        }
       }
       var assets = await Future.wait(allFutureAssets);
       jsAssets.addAll(assets.where((asset) => asset != null));
 
       return jsAssets;
     } catch (e) {
       logError(e);
       return new AssetSet();
     }
   }
@@ skipping 38 matching lines @@
     } else if (id.path.endsWith(linkedSummaryExtension)) {
       assets = {
         id: createLinkedSummary(id, _moduleReader, _scratchSpace, logError)
       };
     } else if (_isEntrypointId(id)) {
       var dartId = _entrypointDartId(id);
       if (dartId != null) {
         assets = bootstrapDartDevcEntrypoint(
             dartId, _mode, _moduleReader, _barback.getAssetById);
       }
-    } else if (id.path.endsWith('require.js') ||
-        id.path.endsWith('dart_sdk.js')) {
+    } else if (_hasJsResource(id)) {
       assets = {id: _buildJsResource(id)};
     } else if (id.path.endsWith('require.js.map') ||
         id.path.endsWith('dart_sdk.js.map')) {
       assets = {id: new Future.error(new AssetNotFoundException(id))};
     } else if (id.path.endsWith('.js') || id.path.endsWith('.js.map')) {
       var jsId = id.extension == '.map' ? id.changeExtension('') : id;
       assets = createDartdevcModule(jsId, _moduleReader, _scratchSpace,
           _environmentConstants, _mode, logError);
       // Pre-emptively start building all transitive JS deps under the
       // assumption they will be needed in the near future.
@@ skipping 26 matching lines @@
         asset.id.package == id.package &&
         asset.id.extension == '.dart' &&
         topLevelDir(asset.id.path) == moduleDir);
     if (moduleAssets.isEmpty) throw new AssetNotFoundException(id);
     var moduleMode =
         moduleDir == 'lib' ? ModuleMode.public : ModuleMode.private;
     var modules = await computeModules(moduleMode, moduleAssets);
     var encoded = JSON.encode(modules);
     return new Asset.fromString(id, encoded);
   }
 

[Bob Nystrom, 2017/05/22 20:21:44]

Doc comment?

-  /// Builds the `dart_sdk.js` or `require.js` assets by copying them from the
-  /// SDK.
+  bool _hasJsResource(AssetId id) =>
+      _sdkResources.containsKey(p.url.basename(id.path));
+
+  /// Builds [_sdkResources] assets by copying them from the SDK.
   Future<Asset> _buildJsResource(AssetId id) async {
     var sdk = cli_util.getSdkDir();
-
-    switch (p.url.basename(id.path)) {
-      case 'dart_sdk.js':
-        var sdkAmdJsPath =
-            p.url.join(sdk.path, 'lib/dev_compiler/amd/dart_sdk.js');
-        return new Asset.fromPath(id, sdkAmdJsPath);
-      case 'require.js':
-        var requireJsPath =
-            p.url.join(sdk.path, 'lib/dev_compiler/amd/require.js');
-        return new Asset.fromFile(id, new File(requireJsPath));
-      default:
-        return null;
-    }
+    var basename = p.url.basename(id.path);
+    var resourcePath = _sdkResources[basename];
+    if (resourcePath == null) return null;
+    return new Asset.fromPath(id, p.url.join(sdk.path, resourcePath));
   }
 
   /// Whether or not this looks like a request for an entrypoint or bootstrap
   /// file.
   bool _isEntrypointId(AssetId id) =>
       id.path.endsWith('.bootstrap.js') ||
       id.path.endsWith('.bootstrap.js.map') ||
       id.path.endsWith('.dart.js') ||
       id.path.endsWith('.dart.js.map');
 
@@ skipping 76 matching lines @@
 
   /// Reads a [Result] from the actual underlying caches, or returns `null`.
   Future<Result> _getResult(AssetId id) {
     var packageCache = _assets[id.package];
     if (packageCache == null) return null;
     var futureResult = packageCache[id.path];
     if (futureResult == null) return null;
     return futureResult;
   }
 }