Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Issue 289343004: Revert 272478 "Always define _HAS_EXCEPTIONS=0 on Windows" (Closed)

Created:
6 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 7 months ago
Reviewers:
hans
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 272478 "Always define _HAS_EXCEPTIONS=0 on Windows" Caused assertion failures in multiple test suites. BUG=82385, 377008 > Always define _HAS_EXCEPTIONS=0 on Windows > > Previously we would not define it in component builds because it didn't work with old versions of MSVC. These days it should work. > > The macro is extra important for Clang, which doesn't currently support exceptions on Windows. > > BUG=82385 > > Review URL: https://codereview.chromium.org/287193012 TBR=hans@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272610

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M trunk/src/build/common.gypi View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
6 years, 7 months ago (2014-05-23 22:10:59 UTC) #1
Ken Russell (switch to Gerrit)
Committed patchset #1 manually as r272610.
6 years, 7 months ago (2014-05-23 22:11:05 UTC) #2
hans
On 2014/05/23 22:11:05, Ken Russell wrote: > Committed patchset #1 manually as r272610. Sorry about ...
6 years, 7 months ago (2014-05-23 22:14:39 UTC) #3
hans
6 years, 7 months ago (2014-05-23 22:16:07 UTC) #4
Message was sent while issue was closed.
On 2014/05/23 22:14:39, hans wrote:
> On 2014/05/23 22:11:05, Ken Russell wrote:
> > Committed patchset #1 manually as r272610.
> 
> Sorry about the breakage. Do you have a link to any build logs exposing the
> assertion failures?

Ah, just found crbug.com/377008.

Powered by Google App Engine
This is Rietveld 408576698