Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: public/platform/WebNetworkConnection.h

Issue 289333003: Adds type information to the NetworkStateNotifier. Also allows for registration of observers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebNetworkStateNotifier.cpp ('k') | public/web/WebNetworkStateNotifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebNetworkConnection.h
diff --git a/public/platform/WebCanvas.h b/public/platform/WebNetworkConnection.h
similarity index 82%
copy from public/platform/WebCanvas.h
copy to public/platform/WebNetworkConnection.h
index d0de44c6e4f57fcadb48288e7b1baf1216c93736..54d5e3f1662824e64837c4e24e2b23f71042c147 100644
--- a/public/platform/WebCanvas.h
+++ b/public/platform/WebNetworkConnection.h
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2009 Google Inc. All rights reserved.
+ * Copyright (C) 2014 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -28,16 +28,24 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef WebCanvas_h
-#define WebCanvas_h
+#ifndef WebNetworkConnection_h
+#define WebNetworkConnection_h
#include "WebCommon.h"
-class SkCanvas;
-
namespace blink {
-typedef SkCanvas WebCanvas;
+struct WebNetworkConnection {
jochen (gone - plz use gerrit) 2014/05/22 11:05:59 any reason you put the enum inside a struct?
jkarlin 2014/05/22 11:27:37 Done.
+ // Connection types from http://w3c.github.io/netinfo/.
+ enum ConnectionType {
jochen (gone - plz use gerrit) 2014/05/22 11:05:59 I'd name this WebConnectionType, or the method bel
jkarlin 2014/05/22 11:27:37 Done.
+ Cellular = 0,
jochen (gone - plz use gerrit) 2014/05/22 11:05:59 enums should start with the name of the enum, e.g.
jkarlin 2014/05/22 11:27:37 Done.
+ Bluetooth,
+ Ethernet,
+ Wifi,
+ Other,
+ None
jochen (gone - plz use gerrit) 2014/05/22 11:05:59 if you intend this send this over IPC, you'll want
jkarlin 2014/05/22 11:27:37 Done.
+ };
+};
} // namespace blink
« no previous file with comments | « Source/web/WebNetworkStateNotifier.cpp ('k') | public/web/WebNetworkStateNotifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698