Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc

Issue 28933003: Delete PNaCl translation cache backend object when no longer needed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add dcheck Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/nacl_host/pnacl_translation_cache.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/nacl_host/pnacl_translation_cache.h" 5 #include "chrome/browser/nacl_host/pnacl_translation_cache.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
11 #include "components/nacl/common/pnacl_types.h" 11 #include "components/nacl/common/pnacl_types.h"
12 #include "content/public/browser/browser_thread.h" 12 #include "content/public/browser/browser_thread.h"
13 #include "content/public/test/test_browser_thread_bundle.h" 13 #include "content/public/test/test_browser_thread_bundle.h"
14 #include "net/base/io_buffer.h" 14 #include "net/base/io_buffer.h"
15 #include "net/base/test_completion_callback.h" 15 #include "net/base/test_completion_callback.h"
16 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
17 17
18 using content::BrowserThread; 18 using content::BrowserThread;
19 using base::FilePath; 19 using base::FilePath;
20 20
21 namespace pnacl { 21 namespace pnacl {
22 22
23 const int kTestDiskCacheSize = 16 * 1024 * 1024; 23 const int kTestDiskCacheSize = 16 * 1024 * 1024;
24 24
25 class PnaclTranslationCacheTest : public testing::Test { 25 class PnaclTranslationCacheTest : public testing::Test {
26 protected: 26 protected:
27 PnaclTranslationCacheTest() 27 PnaclTranslationCacheTest()
28 : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {} 28 : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {}
29 virtual ~PnaclTranslationCacheTest() {} 29 virtual ~PnaclTranslationCacheTest() {}
30 virtual void SetUp() { cache_ = new PnaclTranslationCache(); } 30 virtual void SetUp() { cache_.reset(new PnaclTranslationCache()); }
31 virtual void TearDown() { 31 virtual void TearDown() {
32 // The destructor of PnaclTranslationCacheWriteEntry posts a task to the IO 32 // The destructor of PnaclTranslationCacheWriteEntry posts a task to the IO
33 // thread to close the backend cache entry. We want to make sure the entries 33 // thread to close the backend cache entry. We want to make sure the entries
34 // are closed before we delete the backend (and in particular the destructor 34 // are closed before we delete the backend (and in particular the destructor
35 // for the memory backend has a DCHECK to verify this), so we run the loop 35 // for the memory backend has a DCHECK to verify this), so we run the loop
36 // here to ensure the task gets processed. 36 // here to ensure the task gets processed.
37 base::RunLoop().RunUntilIdle(); 37 base::RunLoop().RunUntilIdle();
38 delete cache_; 38 cache_.reset();
39 } 39 }
40 40
41 void InitBackend(bool in_mem); 41 void InitBackend(bool in_mem);
42 void StoreNexe(const std::string& key, const std::string& nexe); 42 void StoreNexe(const std::string& key, const std::string& nexe);
43 std::string GetNexe(const std::string& key); 43 std::string GetNexe(const std::string& key);
44 44
45 PnaclTranslationCache* cache_; 45 scoped_ptr<PnaclTranslationCache> cache_;
46 content::TestBrowserThreadBundle thread_bundle_; 46 content::TestBrowserThreadBundle thread_bundle_;
47 base::ScopedTempDir temp_dir_; 47 base::ScopedTempDir temp_dir_;
48 }; 48 };
49 49
50 void PnaclTranslationCacheTest::InitBackend(bool in_mem) { 50 void PnaclTranslationCacheTest::InitBackend(bool in_mem) {
51 net::TestCompletionCallback init_cb; 51 net::TestCompletionCallback init_cb;
52 if (!in_mem) { 52 if (!in_mem) {
53 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); 53 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
54 } 54 }
55 // Use the private init method so we can control the size 55 // Use the private init method so we can control the size
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 StoreNexe(test_key, test_store_val); 260 StoreNexe(test_key, test_store_val);
261 TestNexeCallback load_cb; 261 TestNexeCallback load_cb;
262 std::string nexe; 262 std::string nexe;
263 cache_->GetNexe(test_key + "a", load_cb.callback()); 263 cache_->GetNexe(test_key + "a", load_cb.callback());
264 int rv; 264 int rv;
265 scoped_refptr<net::DrainableIOBuffer> buf(load_cb.GetResult(&rv)); 265 scoped_refptr<net::DrainableIOBuffer> buf(load_cb.GetResult(&rv));
266 EXPECT_EQ(net::ERR_FAILED, rv); 266 EXPECT_EQ(net::ERR_FAILED, rv);
267 } 267 }
268 268
269 } // namespace pnacl 269 } // namespace pnacl
OLDNEW
« no previous file with comments | « chrome/browser/nacl_host/pnacl_translation_cache.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698