Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2893293002: Share more logic between the Ssa(Ast)Builder and SsaKernelBuilder (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Share more logic between the Ssa(Ast)Builder and SsaKernelBuilder This is a preparational step towards generating SSA from kernel based elements. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/f8dc775b44b17f902f32a7c724e241e9b0cdc5b0

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Rebased #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -78 lines) Patch
M pkg/compiler/lib/src/dump_info.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 5 chunks +11 lines, -47 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +63 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 2 3 chunks +7 lines, -5 lines 2 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 3 chunks +15 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-22 13:33:52 UTC) #2
Johnni Winther
PTAL
3 years, 7 months ago (2017-05-23 09:12:07 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2893293002/diff/40001/pkg/compiler/lib/src/ssa/builder_kernel.dart File pkg/compiler/lib/src/ssa/builder_kernel.dart (right): https://codereview.chromium.org/2893293002/diff/40001/pkg/compiler/lib/src/ssa/builder_kernel.dart#newcode47 pkg/compiler/lib/src/ssa/builder_kernel.dart:47: class SsaKernelBuilderTask extends SsaAstBuilderBase { Just to be ...
3 years, 7 months ago (2017-05-23 21:17:30 UTC) #4
Johnni Winther
https://codereview.chromium.org/2893293002/diff/40001/pkg/compiler/lib/src/ssa/builder_kernel.dart File pkg/compiler/lib/src/ssa/builder_kernel.dart (right): https://codereview.chromium.org/2893293002/diff/40001/pkg/compiler/lib/src/ssa/builder_kernel.dart#newcode47 pkg/compiler/lib/src/ssa/builder_kernel.dart:47: class SsaKernelBuilderTask extends SsaAstBuilderBase { On 2017/05/23 21:17:30, Siggi ...
3 years, 7 months ago (2017-05-24 07:54:46 UTC) #5
Johnni Winther
3 years, 7 months ago (2017-05-24 07:59:29 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
f8dc775b44b17f902f32a7c724e241e9b0cdc5b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698