Source/web/WebViewImpl.cpp - Issue 289323003: Move markerlists to Oilpan heap and remove finalizer from DocumentMarkerController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 289323003: Move markerlists to Oilpan heap and remove finalizer from DocumentMarkerController (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Move DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 4ba3f0cac83701f6a1535202b38c4d5ba6022374..13adddc17742a6de24be7cbeacede37e8e914a24 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -3244,7 +3244,7 @@ void WebViewImpl::spellingMarkers(WebVector<uint32_t>* markers)

{

Vector<uint32_t> result;

for (LocalFrame* frame = m_page->mainFrame(); frame; frame = frame->tree().traverseNext()) {

- const Vector<DocumentMarker*>& documentMarkers = frame->document()->markers().markers();

+ const WillBeHeapVector<DocumentMarker*>& documentMarkers = frame->document()->markers().markers();

for (size_t i = 0; i < documentMarkers.size(); ++i)

result.append(documentMarkers[i]->hash());

}

« no previous file with comments | « Source/web/WebLocalFrameImpl.cpp ('k') | no next file » | no next file with comments »